Date: Sat, 15 Jun 2002 20:32:54 -0700 From: Doug Barton <DougB@FreeBSD.org> To: Ade Lovett <ade@FreeBSD.org> Cc: Akinori MUSHA <knu@iDaemons.org>, Trevor Johnson <trevor@jpj.net>, Mikhail Teterin <mi+mx@aldan.algebra.com>, Pete Fritchman <petef@absolutbsd.org>, portmgr@FreeBSD.org, Maxim Sobolev <sobomax@FreeBSD.org>, ports@FreeBSD.org, jmallett@FreeBSD.org Subject: Re: REINPLACE Message-ID: <3D0C06E6.7B114900@FreeBSD.org> References: <B931592E.11EA7%ade@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ade Lovett wrote:
>
> On 06/14/02 18:15, "Doug Barton" <DougB@FreeBSD.org> wrote:
>
> > At tremendous risk to my sanity, I'm going to try and make a rather
> > obvious point one more time. You guys are putting a tremendous amount of
> > effort into this REINPLACE stuff in order to avoid the simple, clean
> > solution of not doing the patching 'in place' at all. I have the following
> > (or something similar) in several of my ports:
> >
> > post-patch:
> > @ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
> > @ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
> > ${WRKSRC}/configure.Patched > ${WRKSRC}/configure
Please tell me that you really are not so lacking in imagination.
> Two things:
>
> doesn't take into account multiple files (for-loop or xargs)
I use this exact technique in for loops in my ports. Take a look at
xscreensaver for example. It used to have more files that needed the
malloc patch, but at this moment in time it only has one. The code above
works just as well in a for loop or not.
> leaves *.Patched turds lying around, which may cause PLIST breakage
In the rare circumstance that this matters, you could use .orig if it
makes you feel better (since we'd have to deal with that anyway). The
other alternative is to simply remove the files, like it's sometimes
necessary to do with the .orig files. Look at Spam Assassin for an
example of that.
Plain and simple, this works. It also eliminates 90% of the silliness
that y'all are considering. Of course, for some that's a point against
my proposal. :)
Doug
--
"We have known freedom's price. We have shown freedom's power.
And in this great conflict, ... we will see freedom's victory."
- George W. Bush, President of the United States
State of the Union, January 28, 2002
Do YOU Yahoo!?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D0C06E6.7B114900>