From owner-svn-src-all@freebsd.org Thu Feb 28 21:44:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33D81151A6C4; Thu, 28 Feb 2019 21:44:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A3B6D8ABE3; Thu, 28 Feb 2019 21:44:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x535.google.com with SMTP id m1so10340664pgq.8; Thu, 28 Feb 2019 13:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oxQAmoi9JosCui8gor/cCpYa0DfwR2ux5G4hapXNM1M=; b=SnAzupOydEshRKtwctitKxT91MugJG3qxiyDty9XgvTGjosWkxajvUl43psSObyo8Q ZFRTa45KpNyLSA26WpnBzCGZsaPcUquf5jaq6sEoIRdohoy79R0xsJH14Qeq7rwgVsS5 dcbXtTEPyLEz4+sv7//u/MLWuyn8PUnZaqX+Q9MiwGiF5HlUHHID5wX/OPXWulFoKPKn wcraqux1zsXrc3/UyFf9PtACKJTCUvebiJMj2NSqBfRkN8GR6t4K8SNt8TP+Bw8HGweW NVMY6h0nAz0NXCONx19AQoivE+yjcHRaslTdMPhKv5vsJaGuOAqv3Lk5DVsflBlmY8zG t2yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oxQAmoi9JosCui8gor/cCpYa0DfwR2ux5G4hapXNM1M=; b=PI5KRtK2c4JuCyYPS/Xl93SStY7b1rsWgoyxjtXbYPjSe4edwwe1E8vjupzrycVkGm NJ4pY0+fpOolh634koI0YQqSQaX7ljzGMFc8bK6RJWazIK07IVTxDXojJZebvvTtNbcz /NK0p5Kc4j3PKmqH1XgkJZGmQUs/YExxz4CgxiDOyIHy4JZQLoEvo+HFhpJbZymk2ozD SQC6XNphuGFm13XWgrNLs39JIhTtmujUBjeq5/ZW8jDIJ1iCRHhhSLtDkMz56zH7amU/ 5fuTYxQiyoVjW29U1GwnT6lF4VYRhQlWjKa+G7dksmDqo+EYZ2v7kcJlVCIKHxEPA1Jb yTDw== X-Gm-Message-State: APjAAAU2sVugVuF5UpDWM0C/JQ6auK4YXnFnmmMj6Biq3jK2TlPSmqcl yKhlhL+jXU4RWOUpyijiccC5YEBW X-Google-Smtp-Source: APXvYqzQWo+aIfaBWUIe0yoLfE29OhFE2EJaicH4k1J9DNG0GJDw7//TUxXLQgybPhS3lpLIF/Pedg== X-Received: by 2002:a65:654d:: with SMTP id a13mr1317326pgw.181.1551390273259; Thu, 28 Feb 2019 13:44:33 -0800 (PST) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n6sm28730135pfa.3.2019.02.28.13.44.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 13:44:32 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344666 - head/tools/build/mk From: Enji Cooper In-Reply-To: <201902282048.x1SKmILE082786@repo.freebsd.org> Date: Thu, 28 Feb 2019 13:44:31 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <0EC04D65-721E-49F1-9755-7A8FDDE554DB@gmail.com> References: <201902282048.x1SKmILE082786@repo.freebsd.org> To: Bryan Drewery X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: A3B6D8ABE3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.979,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 21:44:35 -0000 > On Feb 28, 2019, at 12:48 PM, Bryan Drewery = wrote: >=20 > Author: bdrewery > Date: Thu Feb 28 20:48:18 2019 > New Revision: 344666 > URL: https://svnweb.freebsd.org/changeset/base/344666 >=20 > Log: > bsd.nls.mk isn't optional. >=20 > It is protected by MK_NLS. If it should really be optional then > it needs to be documented as such in share/mk/bsd.README and > .sinclude used where needed. >=20 > This fixes a regression from r335011. >=20 > PR: 232527 > Submitted by: jarrod@downtools.com.au > Reported by: ktullavik@gmail.com > MFC after: 3 days Should bsd.{lib,prog}.mk instead be taught to ignore errors when = including this file? Thanks! -Enji=