From owner-svn-src-head@FreeBSD.ORG Sun Apr 12 14:36:25 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A92CE10656F0; Sun, 12 Apr 2009 14:36:25 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129]) by mx1.freebsd.org (Postfix) with ESMTP id 6449F8FC2A; Sun, 12 Apr 2009 14:36:25 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 6CF8673098; Sun, 12 Apr 2009 16:41:37 +0200 (CEST) Date: Sun, 12 Apr 2009 16:41:37 +0200 From: Luigi Rizzo To: Robert Watson Message-ID: <20090412144137.GD96365@onelab2.iet.unipi.it> References: <200904121406.n3CE6QSH027497@svn.freebsd.org> <20090412143000.GB96365@onelab2.iet.unipi.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: per-cpu counters (Re: svn commit: r190967 - head/sys/netinet) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2009 14:36:27 -0000 On Sun, Apr 12, 2009 at 03:29:38PM +0100, Robert Watson wrote: > > On Sun, 12 Apr 2009, Robert Watson wrote: > > >>As an example, an approach i was considering is replace the existing > >>counters with an index in a global_counters[MAXCPU][] array so the > >>counter update will become something like this: > > FYI, one other reason to put it all behind per-subsystem macros is that it > allows us to easily prototype another statistics implementation, the no-op, > on a per-subsystem basis. good point, i didn't consider this.