From owner-freebsd-audit  Fri Jun 22 17: 9:57 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from iatl0x01.coxmail.com (iatl1x01.coxmail.com [206.157.231.23])
	by hub.freebsd.org (Postfix) with ESMTP
	id E861A37B409; Fri, 22 Jun 2001 17:09:53 -0700 (PDT)
	(envelope-from mheffner@novacoxmail.com)
Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178])
          by iatl0x01.coxmail.com
          (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2)
          with ESMTP
          id <20010623000953.STC1034.iatl0x01@enterprise.muriel.penguinpowered.com>;
          Fri, 22 Jun 2001 20:09:53 -0400
Message-ID: <XFMail.20010622200946.mheffner@novacoxmail.com>
X-Mailer: XFMail 1.4.7 on FreeBSD
X-Priority: 3 (Normal)
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_";
 micalg=pgp-md5; protocol="application/pgp-signature"
In-Reply-To: <20010622033201.B506@dragon.nuxi.com>
MYHEADER: test
Date: Fri, 22 Jun 2001 20:09:46 -0400 (EDT)
Reply-To: Mike Heffner <mheffner@vt.edu>
From: Mike Heffner <mheffner@novacoxmail.com>
To: "David O'Brien" <obrien@freebsd.org>
Subject: Re: whois(1) patch
Cc: freebsd-audit@freebsd.org, Mike Barcroft <mike@q9media.com>,
	phk@freebsd.org
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

This message is in MIME format
--_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_
Content-Type: text/plain; charset=us-ascii


On 22-Jun-2001 David O'Brien wrote:
| On Thu, May 31, 2001 at 02:30:21PM -0400, Mike Barcroft wrote:
|> > | It does the following:
|> > | 
|> > |  o Silence warnings and set WARNS=2
|> > |  o Fix two memory leaks
|> > |  o asprint -> strdup where appropriate
|> > |  o calloc/strcpy/strcat -> aprintf
|> > |  o Convert to ANSI C to avoid having to prototype main()
| 
| 
| You should separate your patches into functionality and style(9).
| I see DES just committed this patch as is, rather than break it into two
| parts as our practices says it should have been.
| 
| You also changed puts() to printf().  Was there a reason for making that
| change?

Probably because style(9) mentions it:

        Use printf(3), not fputs/puts/putchar/whatever; it's faster and usually
        cleaner, not to mention avoiding stupid bugs.


Mike

-- 
  Mike Heffner               <mheffner@vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>
      http://filebox.vt.edu/users/mheffner


--_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE7M95KFokZQs3sv5kRAkzCAJ0aki4jqpHbqBxMurtLevRFjRqqOwCfUHCA
XdaCAeo8kyaFr0i0yhjmTu8=
=vCHc
-----END PGP SIGNATURE-----

--_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_--
End of MIME message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message