From owner-cvs-all Fri Apr 12 16:19:40 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 7C36B37B416; Fri, 12 Apr 2002 16:19:34 -0700 (PDT) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g3CNJRw19871; Fri, 12 Apr 2002 19:19:27 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 12 Apr 2002 19:19:26 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Coleman Kane Cc: John Baldwin , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, cvs@FreeBSD.org Subject: Re: cvs commit: src/sys/pci agp_amd.c agpreg.h In-Reply-To: <20020412141839.B41510@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 12 Apr 2002, Coleman Kane wrote: > Alright, I will do that. The code currently causes crashes (to kdb) in > RELENG_4_5 when enabled, so that's why I committed it. This suggests we need some sort of access control on the branch -- this isn't the first "oops, I didn't realize" commit, but these commits really muck up automated version control for patches. Please ask cvs@ to remove the change from CVS using CVS editing magic. > > -- > coleman > > On Fri, Apr 12, 2002 at 01:22:28PM -0400, John Baldwin wrote: > > > > On 12-Apr-2002 Coleman Kane wrote: > > > cokane 2002/04/12 10:05:48 PDT > > > > > > Modified files: (Branch: RELENG_4_5) > > > sys/pci agp_amd.c agpreg.h > > > Log: > > > This should fix the lock-ups associated with AGP and AMD761 chips. > > > The previous revision was rather hastily MFC'd before the 761 got any > > > real testing. > > > > > > Obtained from: Eirc Anholt > > > > Commits to the RELENG_X_Y branches (aka release branches) need to be > > approved by either the release engineers or the security officer team. > > You should probably back this out and run it by re@ first. For one thing > > there are extra steps involved with committing changes to these branches > > including adding a note to UPDATING and bumping the patch version. > > > > -- > > > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message