Date: Tue, 21 Oct 2008 07:45:53 +0000 From: Norbert Koch <nkoch@demig.de> To: freebsd-hackers@freebsd.org, freebsd-threads@freebsd.org Subject: 'libc_r: enter/leave_cancellation_point() Message-ID: <48FD88B1.3050106@demig.de>
next in thread | raw e-mail | index | archive | help
Hello,
I was just inspecting libc_r for trying to understand
some things and found this:
<-------------------------
--- src/lib/libc_r/uthread/uthread_cond.c 2002/05/24 04:32:28 1.33
+++ src/lib/libc_r/uthread/uthread_cond.c 2002/11/13 18:13:26 1.34
...
int
-_pthread_cond_signal(pthread_cond_t * cond)
+__pthread_cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex,
+ const struct timespec *abstime)
+{
+ int ret;
+
+ _thread_enter_cancellation_point();
+ ret = _pthread_cond_timedwait(cond, mutex, abstime);
+ _thread_enter_cancellation_point();
+ return (ret);
+}
---------------------------->
Shouldn't that be _thread_leave_cancellation_point() after
calling _pthread_cond_timedwait() ?
What effect should I see if this is wrong?
Best regards,
Norbert Koch
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48FD88B1.3050106>