From owner-svn-src-all@freebsd.org  Sun Feb 14 15:37:14 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE0C8AA8CDF;
 Sun, 14 Feb 2016 15:37:14 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8A2A51F7F;
 Sun, 14 Feb 2016 15:37:14 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 7E5451FE023;
 Sun, 14 Feb 2016 16:37:09 +0100 (CET)
Subject: Re: svn commit: r295607 - head/sys/dev/usb/wlan
To: Adrian Chadd <adrian.chadd@gmail.com>,
 Andriy Voskoboinyk <s3erios@gmail.com>
References: <201602140716.u1E7Gaot040504@repo.freebsd.org>
 <CAJ-Vmo=9cCtdY5_a_mQVm5h5an7F=H75uw7LYu9uK3UEA5n0Vg@mail.gmail.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <56C09FB4.4000201@selasky.org>
Date: Sun, 14 Feb 2016 16:39:32 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CAJ-Vmo=9cCtdY5_a_mQVm5h5an7F=H75uw7LYu9uK3UEA5n0Vg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Feb 2016 15:37:14 -0000

On 02/14/16 16:23, Adrian Chadd wrote:
> uhm, why'd you not just file a separate pr for this?
>
> 8 keys limits how many stations it can support in hostap mode :( I'd
> rather the bitmap management code gets fixed.
>

Hi,

 From what I can see 8 keys is the maximum due to the following shift:

         /* Set cipher mode. */
         if (rum_modbits(sc, rvp_id < 2 ? RT2573_SEC_CSR1 : RT2573_SEC_CSR5,
               mode << (rvp_id % 2 + k->wk_keyix) * RT2573_SKEY_MAX,
               RT2573_MODE_MASK << (rvp_id % 2 + k->wk_keyix) * 
RT2573_SKEY_MAX)
             != 0)
                 goto print_err;


It is only about bitmanagement, but about where to actually write those 
bits. Feel free to fix it.

--HPS