From owner-dev-commits-src-all@freebsd.org Fri Aug 27 20:52:50 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2858F667A09; Fri, 27 Aug 2021 20:52:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GxBk96hYHz3Kwj; Fri, 27 Aug 2021 20:52:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CEB322397; Fri, 27 Aug 2021 20:52:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 17RKqn2V015545; Fri, 27 Aug 2021 20:52:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 17RKqnrT015544; Fri, 27 Aug 2021 20:52:49 GMT (envelope-from git) Date: Fri, 27 Aug 2021 20:52:49 GMT Message-Id: <202108272052.17RKqnrT015544@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: f5c6c43d4c39 - main - Add a regression test for ggatec remote code execution MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f5c6c43d4c3910d5f8d61c0fae4582d863baa066 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 20:52:50 -0000 The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=f5c6c43d4c3910d5f8d61c0fae4582d863baa066 commit f5c6c43d4c3910d5f8d61c0fae4582d863baa066 Author: Alan Somers AuthorDate: 2021-08-27 20:40:05 +0000 Commit: Alan Somers CommitDate: 2021-08-27 20:52:45 +0000 Add a regression test for ggatec remote code execution Tests that ggatec appropriately handles unsupported BIO operations, rather than overflowing a buffer. Submitted by: Johannes Bruelltuete PR: 213479 Reviewed by: asomers Differential Revision: https://reviews.freebsd.org/D31318 --- tests/sys/geom/class/gate/ggate_test.sh | 34 +++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/tests/sys/geom/class/gate/ggate_test.sh b/tests/sys/geom/class/gate/ggate_test.sh index 7045d7292a75..d19d250215cc 100644 --- a/tests/sys/geom/class/gate/ggate_test.sh +++ b/tests/sys/geom/class/gate/ggate_test.sh @@ -5,6 +5,39 @@ PLAINFILES=plainfiles PORT=33080 CONF=gg.exports +atf_test_case ggatec_trim cleanup +ggatec_trim_head() +{ + atf_set "descr" "ggatec survives a trim" + atf_set "require.progs" "ggatec" + atf_set "require.user" "root" + atf_set "timeout" 60 +} + +ggatec_trim_body() +{ + load_ggate + + us=$(alloc_ggate_dev) + work=$(alloc_md) + atf_check -e ignore -o ignore dd if=/dev/random of=/dev/$work bs=1m count=1 conv=notrunc + echo $CONF >> $PLAINFILES + echo "localhost RW /dev/$work" > $CONF + atf_check ggated -p $PORT -F $PIDFILE $CONF + atf_check ggatec create -p $PORT -u $us localhost /dev/$work + ggate_dev=/dev/ggate${us} + wait_for_ggate_device ${ggate_dev} + + # ggatec only supports read or write. + atf_check -s not-exit:0 -e ignore -o ignore trim -q -f ${ggate_dev} +} + +ggatec_trim_cleanup() +{ + common_cleanup +} + + atf_test_case ggated cleanup ggated_head() { @@ -133,6 +166,7 @@ atf_init_test_cases() atf_add_test_case ggated atf_add_test_case ggatel_file atf_add_test_case ggatel_md + atf_add_test_case ggatec_trim } alloc_ggate_dev()