From owner-svn-src-head@freebsd.org Mon Jul 18 14:25:18 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39E07B9DABD for ; Mon, 18 Jul 2016 14:25:18 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F357D12CF for ; Mon, 18 Jul 2016 14:25:17 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-it0-x22c.google.com with SMTP id u186so69338748ita.0 for ; Mon, 18 Jul 2016 07:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=XO4vw+7omxcJK7HtqU64jkw4YmvT3n0Nm6jDcapuD1o=; b=UZik9gNk0he9I+eeDGTsqGUsdIYeBUZazNLBwOp9LeOwZqHIzmSoH6TlMdR771M+WB k7Z8sNEDOIhOvJSufCciUlm/2z6/oNBfHtHFntrZwPmafBBUj2uiFYbXZk8amnOW/dIV 8DKw700kZWUJ7CepnFlM4ng9vIK4OT0roylY+4Lr+zLznrH0a31dAVfK14JPtkj7LC6z j3LRtVb7pkVbc0YSWL+HK1UYZA4HFIWHc9SIwW62uftrLRYR6WB/XM4/3oBlbCgWfMbX foj8EueavIgABuWWcfm1RTYZCVRG12Rze7kW6iWkigL9hi5y2ZmsSz8F+El01ka/HZu6 YNJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=XO4vw+7omxcJK7HtqU64jkw4YmvT3n0Nm6jDcapuD1o=; b=AJprj1avpzczAI0GFryhrNSv0fPZOcdFNgqOiFFXRQI5sehasZyG+egTQWH0ycjgYX q82b8ztENkk+pxICDr3Wu7Bjbt2Kv0Wz1CSrUXOLezQd3wlzJB6g3CfusZKHPLI4Tca3 YpYXG24U86cCiWmdYFEhQLjEi5sGqs6uGCYGEdW/9hMW5gvdmO2010ptpEniMybxQsas tPZVtAtlt8uymrs8UlCtHiqc1m2bOUY8mfTZ9AK9M3msqmZ8uWRKOG/kc1SbV7f8bZm4 CVOLlro2MssLQgEZIuq+p61VqBpqMWEKOc5b1W7Ik4Gsw7th6tn28IH3DHT7Tiz9ERaC 6K7g== X-Gm-Message-State: ALyK8tI4/rQhqDmm1LivBIzi6vn7sVSd1EesuPhqaDMFecLdZ4U9v3QBB7DHfEoKhbetyIwfe7NR7bFaoLYOCkJq X-Received: by 10.36.90.79 with SMTP id v76mr33065129ita.16.1468851917008; Mon, 18 Jul 2016 07:25:17 -0700 (PDT) MIME-Version: 1.0 Sender: sobomax@sippysoft.com Received: by 10.36.59.193 with HTTP; Mon, 18 Jul 2016 07:24:42 -0700 (PDT) In-Reply-To: <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> References: <201607180500.u6I501CX063743@repo.freebsd.org> <20ae3dfe-96f4-c897-67d0-71bb94d14858@yandex.ru> From: Maxim Sobolev Date: Mon, 18 Jul 2016 07:24:42 -0700 X-Google-Sender-Auth: dzBhpS6fIDO95zMgElgDpQrwIP0 Message-ID: Subject: Re: svn commit: r302985 - head/sys/geom/label To: "Andrey V. Elsukov" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 14:25:18 -0000 Andrey, are you talking about this: --- r156299 | pjd | 2006-03-04 11:41:54 -0800 (=D1=81=D0=B1, 04 =D0=BC=D0=B0=D1= =80 2006) | 11 lines We need to check if file system size is equal to provider's size, because sysinstall(8) still bogusly puts first partition at offset 0 instead of 16, so glabel/ufs will find file system on slice instead of partition. Before sysinstall is fixed, we must keep this code, which means that we wont't be able to detect UFS file systems created with 'newfs -s ...'. PS. bsdlabel(8) creates partitions properly. MFC after: 3 days --- In which case this particular change has a better chance of working since it's not removing this check but making it less strict. Therefore it might attach to a wrong provider only if first UFS slice is the only one slice on partition (or if the other partition is very small - less than 256 blocks in size). In either of those cases I don't think it makes much difference if we are attaching to a slice or a partition. -Maxim On Sun, Jul 17, 2016 at 10:37 PM, Andrey V. Elsukov wrote: > On 18.07.16 08:00, Maxim Sobolev wrote: > > Author: sobomax > > Date: Mon Jul 18 05:00:01 2016 > > New Revision: 302985 > > URL: https://svnweb.freebsd.org/changeset/base/302985 > > > > Log: > > Relax checking if the privider size matches size recorded in the > > superblock, allowing provider to be bit bigger, i.e. have some > > extra padding after the FS image. That in some cases might be > > a side-effect of using CLOOP format which enforces certain block > > size and trying to compress image that is not exactly the number > > of those blocks in size. The UFS itself does not have any issues > > mounting such padded file systems, so it's what GEOM_LABEL should > > do. > > While you are thinking this is good fix, I expect that this change will > break many installations. This is not first time when this check was > changed. > > -- > WBR, Andrey V. Elsukov > >