From nobody Sat Sep 21 20:51:17 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XB1dC3YNYz5VbH8; Sat, 21 Sep 2024 20:51:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XB1dB5rxDz4bkB; Sat, 21 Sep 2024 20:51:26 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 48LKpIA0000071; Sat, 21 Sep 2024 23:51:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 48LKpIA0000071 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 48LKpHUv000070; Sat, 21 Sep 2024 23:51:17 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 21 Sep 2024 23:51:17 +0300 From: Konstantin Belousov To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a52b30ff98cd - main - sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf Message-ID: References: <202409202109.48KL9RZ1078677@gitrepo.freebsd.org> <867cb5z2c3.fsf@ltc.des.dev> <86y13lx7l5.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86y13lx7l5.fsf@ltc.des.dev> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4XB1dB5rxDz4bkB X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Sat, Sep 21, 2024 at 07:03:18PM +0200, Dag-Erling Smørgrav wrote: > Konstantin Belousov writes: > > Dag-Erling Smørgrav writes: > > > Konstantin Belousov writes: > > > > commit a52b30ff98cdab82af140285fa7fcdf1036fef27 > > > > > > > > sys_pipe: consistently use cr_ruidinfo for accounting of pipebuf > > > > > > > > Tested by: yasu > > > > Sponsored by: The FreeBSD Foundation > >> > MFC after: 1 week > > > This appears to be the opposite of the patch which you posted on > > > -current and which yasu@ tested [...] > > Before committing anything, I did a self-review and remembered that I > > have did a lot of considerations when implementing swap accounting and > > decided that ruid is the right target for charge. > > > > Besides stating the obvious fact above, what do you expect me to answer/ > > react to your mail? > > My point is that the commit message claims the patch was tested by yasu@ > when in fact it wasn't. If you're convinced that this is the correct > solution then that's fine, and it does appear to work, but don't claim > that it's been tested by others when it hasn't. The main part of the patch was to ensure consistency in updates: it must be either always uidinfo, or always ruidinfo. Which one specifically would affect the limit's semantic, but not the buggy behavior you reported.