Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Jul 2018 09:03:14 -0700
From:      jgh <jgh@FreeBSD.org>
To:        "Mathieu Arnold" <mat@FreeBSD.org>
Cc:        <ports-committers@freebsd.org>,  <svn-ports-all@freebsd.org>, <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r474919 - head/net/libnfs
Message-ID:  <164b347f237.d6de4cec38036.3969419311465120374@FreeBSD.org>
In-Reply-To: <20180719084127.okibsktz44tdgasp@atuin.in.mat.cc>
References:  <201807182336.w6INaPZa002319@repo.freebsd.org> <20180719084127.okibsktz44tdgasp@atuin.in.mat.cc>

next in thread | previous in thread | raw e-mail | index | archive | help
---- On Thu, 19 Jul 2018 01:41:27 -0700=C2=A0Mathieu Arnold <mat@FreeBSD.or=
g> wrote ---- On Wed, Jul 18, 2018 at 11:36:25PM +0000, Jason Helfman wrote=
: > Author: jgh > Date: Wed Jul 18 23:36:24 2018 > New Revision: 474919 > U=
RL: https://svnweb.freebsd.org/changeset/ports/474919 > > Log: > - missed a=
 '+" > > PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0229865 > > -PLI=
ST_SUB=3D=C2=A0=C2=A0=C2=A0=C2=A0SHLIB=3D${SHLIB} > +PLIST_SUB+=3D=C2=A0=C2=
=A0=C2=A0=C2=A0SHLIB=3D${SHLIB} Why? The variable has no previous declarati=
on, it does not need appending. -- Mathieu Arnold I was accounting for any =
items being brought in through infrastructure, but not necessarily in the p=
ort. If more appropriate, I can remove. -jgh
From owner-svn-ports-all@freebsd.org  Thu Jul 19 16:17:48 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2431F103FFEC;
 Thu, 19 Jul 2018 16:17:48 +0000 (UTC) (envelope-from 0mp@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CE506979AA;
 Thu, 19 Jul 2018 16:17:47 +0000 (UTC) (envelope-from 0mp@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AF6B52B8B8;
 Thu, 19 Jul 2018 16:17:47 +0000 (UTC) (envelope-from 0mp@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w6JGHlkX016310;
 Thu, 19 Jul 2018 16:17:47 GMT (envelope-from 0mp@FreeBSD.org)
Received: (from 0mp@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w6JGHlPv016308;
 Thu, 19 Jul 2018 16:17:47 GMT (envelope-from 0mp@FreeBSD.org)
Message-Id: <201807191617.w6JGHlPv016308@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: 0mp set sender to 0mp@FreeBSD.org
 using -f
From: Mateusz Piotrowski <0mp@FreeBSD.org>
Date: Thu, 19 Jul 2018 16:17:47 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r474969 - head/devel/arcanist
X-SVN-Group: ports-head
X-SVN-Commit-Author: 0mp
X-SVN-Commit-Paths: head/devel/arcanist
X-SVN-Commit-Revision: 474969
X-SVN-Commit-Repository: ports
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>;
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2018 16:17:48 -0000

Author: 0mp
Date: Thu Jul 19 16:17:47 2018
New Revision: 474969
URL: https://svnweb.freebsd.org/changeset/ports/474969

Log:
  Enable Bash completion.
  
  Arcanist is shipped with a Bash completion script. The script isn't installed
  in the directories of the bash-completion library so it's never activated.
  
  This patch creates a symbolic link to the script in the directories of the
  bash-completion library so that the library is able to pick up the completion
  script for arc when a user requests a command completion for the first time.
  
  Reviewed by:	grembo (maintainer), mat (mentor)
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D16345

Modified:
  head/devel/arcanist/Makefile
  head/devel/arcanist/pkg-plist

Modified: head/devel/arcanist/Makefile
==============================================================================
--- head/devel/arcanist/Makefile	Thu Jul 19 16:03:22 2018	(r474968)
+++ head/devel/arcanist/Makefile	Thu Jul 19 16:17:47 2018	(r474969)
@@ -2,6 +2,7 @@
 
 PORTNAME=	arcanist
 PORTVERSION=	20180420
+PORTREVISION=	1
 CATEGORIES=	devel
 PKGNAMESUFFIX=	${PHP_PKGNAMESUFFIX}
 
@@ -34,5 +35,7 @@ do-install:
 	@${MKDIR} ${STAGEDIR}${PREFIX}/${PHP_DESTDIR}
 	cd ${WRKSRC} ; ${PAX} -rw * ${STAGEDIR}${PREFIX}/${PHP_DESTDIR}
 	${LN} -sf ../${PHP_DESTDIR}/scripts/arcanist.php ${STAGEDIR}${PREFIX}/bin/arc
+	@${MKDIR} ${STAGEDIR}${PREFIX}/share/bash-completion/completions/
+	${RLN} ${STAGEDIR}${PREFIX}/${PHP_DESTDIR}/resources/shell/bash-completion ${STAGEDIR}${PREFIX}/share/bash-completion/completions/arc
 
 .include <bsd.port.mk>

Modified: head/devel/arcanist/pkg-plist
==============================================================================
--- head/devel/arcanist/pkg-plist	Thu Jul 19 16:03:22 2018	(r474968)
+++ head/devel/arcanist/pkg-plist	Thu Jul 19 16:17:47 2018	(r474969)
@@ -921,3 +921,4 @@ lib/php/arcanist/src/workflow/ArcanistWhichWorkflow.ph
 lib/php/arcanist/src/workflow/ArcanistWorkflow.php
 lib/php/arcanist/src/workflow/exception/ArcanistCapabilityNotSupportedException.php
 lib/php/arcanist/src/workingcopyidentity/ArcanistWorkingCopyIdentity.php
+share/bash-completion/completions/arc



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?164b347f237.d6de4cec38036.3969419311465120374>