From owner-svn-src-all@freebsd.org Wed Oct 7 06:24:38 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E41E9D144B; Wed, 7 Oct 2015 06:24:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DCCC09C9; Wed, 7 Oct 2015 06:24:37 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by iow1 with SMTP id 1so11799520iow.1; Tue, 06 Oct 2015 23:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YIJnM532PDw85wTmPAmsDaksFt4d7TG83ZivPEOgapM=; b=ZqJwHTnZecxloSEnRGrcZ2OPcMbNGu4pxdWPJyZ9WfQRf/jZ68BnfYGDKVzRDsPLE6 ASVdAs2LQ8qy2z8kb88K9cvdH+m1JRmjkjtTtgwFKEJTI6OnrZPKPt0RtRaCzlNtZkoR uN7k7qMtjJFfEUKo03mBJC4bK3hTH0UlIXFxn6Jvx7m0y+p+Kkv9gmf/m/E1RSGV+38E 6vGDJWsfaxoZTCCXerx76CFcJcAjIjBnQr8lU0ZjQI77QzfMZeZH01QnAbekgnHX3ceG V7W9xaHm7kI7HD2AZfRLaDPiErRawS/+Al2N7QuAvvNtlBTTBYi61eOaOWrwcGw2kMMv 9Udg== X-Received: by 10.107.135.196 with SMTP id r65mr44960033ioi.131.1444199077210; Tue, 06 Oct 2015 23:24:37 -0700 (PDT) Received: from ?IPv6:2601:601:800:126d:74ff:5034:d9e4:f4ee? ([2601:601:800:126d:74ff:5034:d9e4:f4ee]) by smtp.gmail.com with ESMTPSA id 39sm13861316ioh.38.2015.10.06.23.24.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 06 Oct 2015 23:24:36 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r288907 - head/bin/ls/tests From: NGie Cooper In-Reply-To: <2474554.zI8qz6W2Yp@ralph.baldwin.cx> Date: Tue, 6 Oct 2015 23:24:35 -0700 Cc: Garrett Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <53B741C2-C962-41FA-A617-2019BEF2A0D4@gmail.com> References: <201510060100.t9610CXc077196@repo.freebsd.org> <2474554.zI8qz6W2Yp@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 06:24:38 -0000 > On Oct 6, 2015, at 11:26, John Baldwin wrote: >=20 > On Tuesday, October 06, 2015 01:00:12 AM Garrett Cooper wrote: >> Author: ngie >> Date: Tue Oct 6 01:00:12 2015 >> New Revision: 288907 >> URL: https://svnweb.freebsd.org/changeset/base/288907 >>=20 >> Log: >> Call sync consistently using atf_check >>=20 >> Remove superfluous sync's >=20 > You should not need to call sync() to see the results of earlier = namespace > changes (file create, rename, delete, etc.), even for NFS when looking = on the > same client that made the namespace change. >=20 > Are you doing this to force mtime updates? You should not need sync() = for > that on UFS (ufs_getattr() forces any pending lazy timestamp updates). = You > would for NFS (not sure about ZFS). >=20 > Whatever the reason for the syncs, I think it warrants a comment. You=E2=80=99re right about it not being clear as to why they=E2=80=99re = there. I ran into issues earlier on when developing the test cases, but it = might have been how I wrote them, along with bugs I fixed while = developing them. I=E2=80=99ll retest without the syncs. Depending on the outcome I=E2=80=99= ll either remove them entirely or comment on why they=E2=80=99re there. = I=E2=80=99ll probably do a combination of both if I run into issues. Thanks :)! -NGie PS I run my tests with UFS and atime on, mostly, but I also use ZFS = periodically. My work system runs ZFS, but I=E2=80=99m a few months = behind because of deliverables in flight and having to take down the = system/risk an upgrade with the recent churn in ZFS.=