Date: Sun, 24 Jan 2021 18:51:48 +0100 From: Otto Moerbeek <otto@drijf.net> To: Alejandro Colomar <alx.manpages@gmail.com> Cc: Bernhard Voelker <mail@bernhard-voelker.de>, Alex Henrie <alexhenrie24@gmail.com>, Christian Groessler <chris@groessler.org>, =?iso-8859-1?Q?P=E1draig?= Brady <P@draigbrady.com>, Coreutils <coreutils@gnu.org>, William Ahern <william@25thandclement.com>, Erik Auerswald <auerswal@unix-ag.uni-kl.de>, Eric Pruitt <eric.pruitt@gmail.com>, Jeffrey Walton <noloader@gmail.com>, Michael Kerrisk <mtk.manpages@gmail.com>, Fabrice BAUZAC <noon@mykolab.com>, tech@openbsd.org, freebsd-hackers@freebsd.org, linux-api@vger.kernel.org, juli@clockworksquid.com, ed@nuxi.nl, oshogbo@freebsd.org Subject: Re: [PATCH v3 (resend)] tee: Add -q, --quiet, --silent option to not write to stdout Message-ID: <YA2ztHUATu1gOxoV@clue.drijf.net> In-Reply-To: <20210124121845.38293-1-alx.manpages@gmail.com> References: <1f8ce444-35e2-56a7-dbd1-34e885372b11@gmail.com> <20210124121845.38293-1-alx.manpages@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 24, 2021 at 01:18:46PM +0100, Alejandro Colomar wrote:
> This is useful for using tee to just write to a file,
> at the end of a pipeline,
> without having to redirect to /dev/null
>
> Example:
>
> echo 'foo' | sudo tee -q /etc/foo;
>
> is equivalent to the old (and ugly)
You keep repeating "ugly" as the reason you are wanting this.
I consider adding special options to command to solve an imagined
issue that can be solved with a general concept like redirection ugly.
Please stop pushing your diff to this list. So far nobody showed any
interest.
-Otto
>
> echo 'foo' | sudo tee /etc/foo >/dev/null;
>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
>
> Resend as v3. I forgot to change the subject line.
> Everything else is the same as in
> <20210123145356.53962-1-alx.manpages@gmail.com>.
>
> src/tee.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/src/tee.c b/src/tee.c
> index c81faea91..1dfa92cf2 100644
> --- a/src/tee.c
> +++ b/src/tee.c
> @@ -45,6 +45,9 @@ static bool append;
> /* If true, ignore interrupts. */
> static bool ignore_interrupts;
>
> +/* Don't write to stdout */
> +static bool quiet;
> +
> enum output_error
> {
> output_error_sigpipe, /* traditional behavior, sigpipe enabled. */
> @@ -61,6 +64,8 @@ static struct option const long_options[] =
> {"append", no_argument, NULL, 'a'},
> {"ignore-interrupts", no_argument, NULL, 'i'},
> {"output-error", optional_argument, NULL, 'p'},
> + {"quiet", no_argument, NULL, 'q'},
> + {"silent", no_argument, NULL, 'q'},
> {GETOPT_HELP_OPTION_DECL},
> {GETOPT_VERSION_OPTION_DECL},
> {NULL, 0, NULL, 0}
> @@ -93,6 +98,7 @@ Copy standard input to each FILE, and also to standard output.\n\
> "), stdout);
> fputs (_("\
> -p diagnose errors writing to non pipes\n\
> + -q, --quiet, --silent don't write to standard output\n\
> --output-error[=MODE] set behavior on write error. See MODE below\n\
> "), stdout);
> fputs (HELP_OPTION_DESCRIPTION, stdout);
> @@ -130,8 +136,9 @@ main (int argc, char **argv)
>
> append = false;
> ignore_interrupts = false;
> + quiet = false;
>
> - while ((optc = getopt_long (argc, argv, "aip", long_options, NULL)) != -1)
> + while ((optc = getopt_long (argc, argv, "aipq", long_options, NULL)) != -1)
> {
> switch (optc)
> {
> @@ -151,6 +158,10 @@ main (int argc, char **argv)
> output_error = output_error_warn_nopipe;
> break;
>
> + case 'q':
> + quiet = true;
> + break;
> +
> case_GETOPT_HELP_CHAR;
>
> case_GETOPT_VERSION_CHAR (PROGRAM_NAME, AUTHORS);
> @@ -235,8 +246,9 @@ tee_files (int nfiles, char **files)
> break;
>
> /* Write to all NFILES + 1 descriptors.
> - Standard output is the first one. */
> - for (i = 0; i <= nfiles; i++)
> + Standard output is the first one.
> + If 'quiet' is true, write to descriptors 1 and above (omit stdout) */
> + for (i = quiet; i <= nfiles; i++)
> if (descriptors[i]
> && fwrite (buffer, bytes_read, 1, descriptors[i]) != 1)
> {
> --
> 2.30.0
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YA2ztHUATu1gOxoV>