From owner-svn-src-user@FreeBSD.ORG Mon Feb 2 05:24:37 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D201106566B; Mon, 2 Feb 2009 05:24:37 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id CB6018FC18; Mon, 2 Feb 2009 05:24:36 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n125Kukh099444; Sun, 1 Feb 2009 22:20:56 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 01 Feb 2009 22:21:19 -0700 (MST) Message-Id: <20090201.222119.-1303462184.imp@bsdimp.com> To: pyunyh@gmail.com From: "M. Warner Losh" In-Reply-To: <20090202051421.GE43513@michelle.cdnetworks.co.kr> References: <20090202044416.GC43513@michelle.cdnetworks.co.kr> <20090201.215218.1013608033.imp@bsdimp.com> <20090202051421.GE43513@michelle.cdnetworks.co.kr> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, thompsa@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r187978 - user/thompsa/usb/sys/dev/usb2/ethernet X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2009 05:24:37 -0000 In message: <20090202051421.GE43513@michelle.cdnetworks.co.kr> Pyun YongHyeon writes: : On Sun, Feb 01, 2009 at 09:52:18PM -0700, M. Warner Losh wrote: : > In message: <20090202044416.GC43513@michelle.cdnetworks.co.kr> : > Pyun YongHyeon writes: : > : On Sun, Feb 01, 2009 at 08:36:18PM -0700, M. Warner Losh wrote: : > : > In message: <20090201213749.GJ32503@citylink.fud.org.nz> : > : > Andrew Thompson writes: : > : > : On Sun, Feb 01, 2009 at 02:28:08PM -0700, M. Warner Losh wrote: : > : > : > In message: <200902010650.n116obU1045871@svn.freebsd.org> : > : > : > Andrew Thompson writes: : > : > : > : + locked = mtx_owned(&sc->sc_mtx); : > : > : > : + if (!locked) : > : > : > : + AUE_LOCK(sc); : > : > : > : > : > : > You do know this is racy, right? : > : > : : > : > : Yea... It only get called unlocked during mii probe+attach so its fine. : > : > : I havnt actaully checked if its ok to hold a mutex during : > : > : mii_phy_probe() which would make this go away. : > : > : > : > You hold GIANT when probe+attach, which means I think you can't : > : : > : AFAIK this is not true on USB2 and I think this is reason why : > : it have to lock/unlock dance in probe/attach. : > : > It is a newbus requirement that all probe/attach routines have to be : > called with GIANT held. : > : : If this can be done on USB2 it would greatly simplify MII attach : part as well as locks used in MII access routines in all USB2 : ethernet drivers. I vaguely remember I asked for this to HPS, but : he seem to forget about it. I'll take a look into the matter in more detail. It is an absolute requirement of newbus at the moment that any call to device_probe_and_attach(), including bus_generic_attach(). Warner