From owner-freebsd-current@FreeBSD.ORG Tue Apr 7 00:39:45 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF325803 for ; Tue, 7 Apr 2015 00:39:45 +0000 (UTC) Received: from sasl.smtp.pobox.com (pb-smtp1.int.icgroup.com [208.72.237.35]) by mx1.freebsd.org (Postfix) with ESMTP id 8EEC4E62 for ; Tue, 7 Apr 2015 00:39:45 +0000 (UTC) Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 983D447C70; Mon, 6 Apr 2015 20:37:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sasl; bh=3qJwOTuBeW8s 8bhHvTmdmVh6+FY=; b=E9E4DscktZ4vFlDZFeiQN+vQjcki6vUMVeMkxXN7n9Sy 8FFrbDDuIBm5xdqVoRwUya7xDENUn7aDKtxetM4tKrOUgNuVnKlVeljQ8igyODno ggjqRXYJFgZ/rgvVZYhRDRt1Bc8MtdqcEjL6sTp4mtNUKgIDDNjjcOd/75RLGd0= Received: from pb-smtp1.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 84CA647C6F; Mon, 6 Apr 2015 20:37:00 -0400 (EDT) Received: from [192.168.1.103] (unknown [73.164.7.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id DEFF547C6C; Mon, 6 Apr 2015 20:36:59 -0400 (EDT) Message-ID: <552326A2.5000406@badgerio.us> Date: Mon, 06 Apr 2015 19:36:50 -0500 From: Eric Badger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Poul-Henning Kamp Subject: Re: Early use of log() does not end up in kernel msg buffer References: <5514CC6D.3020607@badgerio.us> <2033248.Eu3RHS8lTG@ralph.baldwin.cx> <70135.1428354681@critter.freebsd.dk> In-Reply-To: <70135.1428354681@critter.freebsd.dk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 33DE220E-DCBE-11E4-B911-11859F42C9D4-46178211!pb-smtp1.pobox.com Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2015 00:39:45 -0000 On 04/06/2015 04:11 PM, Poul-Henning Kamp wrote: > -------- > In message <2033248.Eu3RHS8lTG@ralph.baldwin.cx>, John Baldwin writes: > >> I think phk@ broke this back in 70239. Before that the log() function did >> this: >> >> log() >> { >> >> /* log to the msg buffer */ >> kvprintf(fmt, msglogchar, ...); >> >> if (!log_open) { >> /* log to console */ >> kvprintf(fmt, putchar, ...); >> } >> } >> >> I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to >> do this. > The reason was systems not running syslog having slow serial consoles. > Correct me if I've misunderstood, but that doesn't seem to matter here; the proposed change adds logging to the message buffer but leaves logging to the console (when no syslog is listening) unchanged. Eric