From owner-freebsd-net@FreeBSD.ORG Fri Apr 3 17:00:03 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C6247E6E; Fri, 3 Apr 2015 17:00:03 +0000 (UTC) Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com [IPv6:2607:f8b0:4001:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 836B4346; Fri, 3 Apr 2015 17:00:03 +0000 (UTC) Received: by ierf6 with SMTP id f6so94493641ier.2; Fri, 03 Apr 2015 10:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=BCgh2lxAX+83UOtEg0mIJygnRu0ZqHHcoauBI97XUcA=; b=CVPTF7mnq6kUaZK3PFrsXLvXy4mlqTvQKnHJy5/RLlCN8UYCsVop3SQDTv0CFwFRIw JaVRbKzyW2bHmrvoThnhz892SI9NqGqLiAYrBDojwhCUaMG16V9L6V6620XVu2tB2loc kHz8vivHzB8mB5euIqao9UX/mz6nXOT68FKS6v5684mvHWdbDUvY/j9Em8zInS+Q6Kf9 FJzh28x7Q0Wdetpgyv0q+WyaD1GwlFOxYUIboXUSAb7Ve0stB7/hOCE6Jhy55+KqXbY0 aad1uJ0Vkhph/BhQSKNHEpF/2D0oVcQOfBWIqE5Xe8witemKyNqeUYB6sGRI4bGwUhFY pdXQ== MIME-Version: 1.0 X-Received: by 10.50.132.66 with SMTP id os2mr29294372igb.6.1428080402487; Fri, 03 Apr 2015 10:00:02 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Fri, 3 Apr 2015 10:00:02 -0700 (PDT) In-Reply-To: <20150403165411.GC72165@strugglingcoder.info> References: <20150323234214.GU53237@strugglingcoder.info> <20150324154931.GC53237@strugglingcoder.info> <20150330225945.GI10892@strugglingcoder.info> <20150331050628.GJ10892@strugglingcoder.info> <20150331170933.GK10892@strugglingcoder.info> <20150403165411.GC72165@strugglingcoder.info> Date: Fri, 3 Apr 2015 10:00:02 -0700 X-Google-Sender-Auth: kGpZU6IwHXhSWreXesOVVATT6cI Message-ID: Subject: Re: Full 32bit flowid from igb(4) From: Adrian Chadd To: hiren panchasara Content-Type: text/plain; charset=UTF-8 Cc: Jack F Vogel , FreeBSD Net , erj@freebsd.org, Jack Vogel , Jason Wolfe X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2015 17:00:03 -0000 On 3 April 2015 at 09:54, hiren panchasara wrote: > On 03/31/15 at 11:15P, Adrian Chadd wrote: >> Yeah, I think the right thing to do is: >> >> * If the descriptor says it's RSS, then use the flowid + rss type > So, if we have multiqueue, we do everything needed to get RSS > flowid/type. That means, with num_queues > 1 we can just expose those. > >> * else, set it to queue id and set the type to opaque. > > This part becomes irrelevant as it's a single queue case. Do we care > about setting flowid value/type in case of single queue? My whole point with not always setting it is that people may do things to /other/ parts of the driver and suddenly the RSS field isn't the RSS field anymore. Doubly so if you start playing with multiqueue + flowdirector on ixgbe. :) So I'd rather the driver be right and correct - checking if the field /is/ RSS and only setting the flowid+flowtype /if/ the value in that register is an RSS flowid, rather than setting it to whatever's there and hoping it's an RSS value. :) -adrian