From owner-freebsd-fs@FreeBSD.ORG  Fri Apr 27 20:30:13 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5B6DF1065670
	for <freebsd-fs@hub.freebsd.org>; Fri, 27 Apr 2012 20:30:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 46C688FC08
	for <freebsd-fs@hub.freebsd.org>; Fri, 27 Apr 2012 20:30:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3RKUDWW057517
	for <freebsd-fs@freefall.freebsd.org>; Fri, 27 Apr 2012 20:30:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3RKUDmF057516;
	Fri, 27 Apr 2012 20:30:13 GMT (envelope-from gnats)
Date: Fri, 27 Apr 2012 20:30:13 GMT
Message-Id: <201204272030.q3RKUDmF057516@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/167266: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 20:30:13 -0000

The following reply was made to PR kern/167266; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/167266: commit references a PR
Date: Fri, 27 Apr 2012 20:23:35 +0000 (UTC)

 Author: rmacklem
 Date: Fri Apr 27 20:23:24 2012
 New Revision: 234740
 URL: http://svn.freebsd.org/changeset/base/234740
 
 Log:
   Fix a leak of namei lookup path buffers that occurs when a
   ZFS volume is exported via the new NFS server. The leak occurred
   because the new NFS server code didn't handle the case where
   a file system sets the SAVENAME flag in its VOP_LOOKUP() and
   ZFS does this for the DELETE case.
   
   Tested by:	Oliver Brandmueller (ob at gruft.de), hrs
   PR:		kern/167266
   MFC after:	1 month
 
 Modified:
   head/sys/fs/nfsserver/nfs_nfsdport.c
 
 Modified: head/sys/fs/nfsserver/nfs_nfsdport.c
 ==============================================================================
 --- head/sys/fs/nfsserver/nfs_nfsdport.c	Fri Apr 27 20:16:20 2012	(r234739)
 +++ head/sys/fs/nfsserver/nfs_nfsdport.c	Fri Apr 27 20:23:24 2012	(r234740)
 @@ -1047,6 +1047,8 @@ nfsvno_removesub(struct nameidata *ndp, 
  	else
  		vput(ndp->ni_dvp);
  	vput(vp);
 +	if ((ndp->ni_cnd.cn_flags & SAVENAME) != 0)
 +		nfsvno_relpathbuf(ndp);
  	NFSEXITCODE(error);
  	return (error);
  }
 @@ -1086,6 +1088,8 @@ out:
  	else
  		vput(ndp->ni_dvp);
  	vput(vp);
 +	if ((ndp->ni_cnd.cn_flags & SAVENAME) != 0)
 +		nfsvno_relpathbuf(ndp);
  	NFSEXITCODE(error);
  	return (error);
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"