From owner-freebsd-hackers Thu Dec 2 1:16:59 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from oskar.dev.nanoteq.co.za (oskar.dev.nanoteq.co.za [196.7.114.5]) by hub.freebsd.org (Postfix) with ESMTP id 041F8151AA for ; Thu, 2 Dec 1999 01:16:45 -0800 (PST) (envelope-from rbezuide@oskar.dev.nanoteq.co.za) Received: (from rbezuide@localhost) by oskar.dev.nanoteq.co.za (8.9.3/8.9.0) id LAA05956; Thu, 2 Dec 1999 11:12:43 +0200 (SAT) From: Reinier Bezuidenhout Message-Id: <199912020912.LAA05956@oskar.dev.nanoteq.co.za> Subject: Re: Linux ioctl not implemented error In-Reply-To: <384636CC.A184B6D0@scc.nl> from Marcel Moolenaar at "Dec 2, 99 10:07:24 am" To: marcel@scc.nl (Marcel Moolenaar) Date: Thu, 2 Dec 1999 11:12:42 +0200 (SAT) Cc: bright@wintelcom.net, wilko@yedi.iaf.nl, groudier@club-internet.fr, FreeBSD-hackers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL28 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Alfred Perlstein wrote: > > > > > + if (!error) { > > > + lvol = *lvolp; > > > + lvol.channel0 = bsd_vol.vol[0]; > > > + lvol.channel1 = bsd_vol.vol[1]; > > > + lvol.channel2 = bsd_vol.vol[2]; > > > + lvol.channel3 = bsd_vol.vol[3]; > > > > FYI the kernel structures are completely identical, you don't really > > gain anything by doing this convertion. Should this be put in for > > clarity? I'm not sure. > > No. When it's there, you automaticly assume it's there for a reason. > Since the structures are identical, there's no reason for the code to be > there. Very confusing :-) I stand corrected then :) thanx Reinier To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message