From owner-cvs-src@FreeBSD.ORG Mon Oct 29 19:54:25 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB6A716A419; Mon, 29 Oct 2007 19:54:25 +0000 (UTC) (envelope-from lol@chistydom.ru) Received: from hermes.hw.ru (hermes.hw.ru [80.68.240.91]) by mx1.freebsd.org (Postfix) with ESMTP id 9009313C4A3; Mon, 29 Oct 2007 19:54:24 +0000 (UTC) (envelope-from lol@chistydom.ru) Received: from [80.68.244.40] (account a_popov@rbc.ru [80.68.244.40] verified) by hermes.hw.ru (CommuniGate Pro SMTP 5.0.13) with ESMTPA id 196714776; Mon, 29 Oct 2007 10:23:35 +0300 Message-ID: <47258A13.3060109@chistydom.ru> Date: Mon, 29 Oct 2007 10:21:55 +0300 From: Alexey Popov User-Agent: Thunderbird 2.0.0.6 (X11/20070924) MIME-Version: 1.0 To: Alexander Kabaev References: <200710121709.l9CH9iu7075715__38270.1859264218$1192209730$gmane$org@repoman.freebsd.org> <47203DFE.2070800@chistydom.ru> <20071025081700.63a4d71b@kan.dnsalias.net> In-Reply-To: <20071025081700.63a4d71b@kan.dnsalias.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Paul Saab , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/libi386 Makefile pxe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2007 19:54:26 -0000 Hi. Alexander Kabaev wrote: >> Paul Saab wrote: >>> ps 2007-10-12 17:09:44 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/boot/i386/libi386 Makefile pxe.c >>> Log: >>> Do not attempt to make an NFS rpc call if using tftp >>> >>> PR: kern/91720 >>> Submitted by: Ruben Kerkhof >>> >>> Revision Changes Path >>> 1.43 +7 -0 src/sys/boot/i386/libi386/Makefile >>> 1.23 +2 -0 src/sys/boot/i386/libi386/pxe.c >> Didn't you break feature introduced in rev 1.21 of pxe.c ??? >> === >> Allow kernels loaded by pxeboot, which was compiled with >> LOADER_TFTP_SUPPORT, to stll be able to mount NFS root as prescribed >> by DCHP configuration. Since pxeboot is using TFTP to get to the >> files, pxeboot can not rely on NFS to provide it a root directory >> hande as a side effect. pxeboot has to make RPC mount call itself. >> === > > Paul did break it indeed. I agree it's annoying to wait for RPC calls running PXE loader build with TFTP-only support. But I believe this feature was requested by someone just if it was committed. I think there should be more accurate fix, i.e. #define LOADER_TFTP_ONLY or something like this. With best regards, Alexey Popov