From nobody Fri May 5 09:55:50 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCQzp4P54z496Kr; Fri, 5 May 2023 09:55:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCQzp3j3Vz4XhD; Fri, 5 May 2023 09:55:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683280550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8+C8wyejlI56TObHgAZEL/fNGnfK5E+t5O8cHxaFI/c=; b=I6xixwYCQYGoLzdxWyquKSoWeOirIGt+QWP689TFHFCX20fKoch9aCbVaCGQkLrY3YrXh8 KtcucWKyDv+yAxG6NtGMlw1+ruvQVjC4JUiEdFZK21yGgJMdY3UElakMXkItO2nXXVbDqJ ALy9aXJBDslnaUxxjaeojKW4MdVaAi9ktMb9wSr7wwW0bVFMqWIc/fX6vL0z5SCncgxlfe 9mH32paTw6nCz8jhOBCvwEA05uv+vXNhDXs0RU8VVdoAZyBYnQA8YXcAZ+LnmeKNyyz/Xk PM+Xxa361uWNQ/eCxPmil2GZKucxvFjk309TFZh0YG0rtTVxdMe+c7fFWeC0fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683280550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8+C8wyejlI56TObHgAZEL/fNGnfK5E+t5O8cHxaFI/c=; b=AjRtRNGrgJm97QOTo8AvVMgjQgdImXulZYvrJcMi/oztuDlyfovNRIDB7CP7USMpV/Na9w ggRC8yvOFc+rdbV66hMjGHzF9W6CY9jFgBXvlLO9g6ZdSgZboXtxUJYtEn0J94tDa9hax8 +V52cB3L7ujx/6YFJ7nUaLi116Lak+6ZguYjSz7WNU631+WAY4DoWvLzo/DxeL3rBnfRdo z1/ChFVUBt2hFzymIjwZEiuQdy4coa2tEo9lJdlUmZWfQbTP3v7L1sQd53A8WHJvT5ivYJ G0feCB+h4KiVBWO2PhyEuCRvS+mX8ZxHBRm4Y8gslFmv/Vco8IV2JOS2Tt2Z4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683280550; a=rsa-sha256; cv=none; b=XwxhcIXWP6tPQByE34EN2cPxGE2Ig7Y82VdgHTXZ5uK1ejqNPlDOIDcHAproSHjQ8dbXV4 bV+WoefeKfNtyXRbs7CcUy03w9LDX2vdkGB2Kcs1E6T/dG22I8lsL89dSDfyriOJe7HpYr TFVhQ8e6J5nyIWecrTE9zMNUvGJD/AmW2W5Lzbz5HVylXModowbos8PJD21/0yLMQIRBhn 5E/JHMAhfftIGVxB0WgFq34UIDRtoBBd4UDuOdaP8uXbNM4wOMlgMIK1qhE8MVkI0g22as 8oKGQgQfj7zguI/twqLQvZRUUP3qpmDCsbsXeHUvIp1uACtqibNlhXAwQEk2nQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QCQzp2kbhzqdB; Fri, 5 May 2023 09:55:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3459toZ1067889; Fri, 5 May 2023 09:55:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3459to8l067888; Fri, 5 May 2023 09:55:50 GMT (envelope-from git) Date: Fri, 5 May 2023 09:55:50 GMT Message-Id: <202305050955.3459to8l067888@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Yuri Pankov Subject: git: 6abf81b3d674 - main - pvscsi: maximum target number is one less than number of targets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: yuripv X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6abf81b3d6747da0baa90860d5a6e929c97c9bb9 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by yuripv: URL: https://cgit.FreeBSD.org/src/commit/?id=6abf81b3d6747da0baa90860d5a6e929c97c9bb9 commit 6abf81b3d6747da0baa90860d5a6e929c97c9bb9 Author: Yuri Pankov AuthorDate: 2023-05-05 09:48:57 +0000 Commit: Yuri Pankov CommitDate: 2023-05-05 09:51:44 +0000 pvscsi: maximum target number is one less than number of targets Fix the number of targets we inquiry to be one less than the maximum number of targets adapter reports. This gets rid of the errors reported on VMware Workstation: (probe36:pvscsi0:0:65:0): INQUIRY. CDB: 12 00 00 00 24 00 (probe36:pvscsi0:0:65:0): CAM status: CCB request completed with an error While here, print the maximum number of targets. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D39867 --- sys/dev/vmware/pvscsi/pvscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/vmware/pvscsi/pvscsi.c b/sys/dev/vmware/pvscsi/pvscsi.c index 1ba4777da906..48650647c561 100644 --- a/sys/dev/vmware/pvscsi/pvscsi.c +++ b/sys/dev/vmware/pvscsi/pvscsi.c @@ -1412,7 +1412,7 @@ finish_ccb: cpi->hba_misc = PIM_NOBUSRESET | PIM_UNMAPPED; cpi->hba_eng_cnt = 0; /* cpi->vuhba_flags = 0; */ - cpi->max_target = sc->max_targets; + cpi->max_target = sc->max_targets - 1; cpi->max_lun = 0; cpi->async_flags = 0; cpi->hpath_id = 0; @@ -1684,6 +1684,7 @@ pvscsi_attach(device_t dev) PVSCSI_MAX_REQ_QUEUE_DEPTH); device_printf(sc->dev, "Use Msg: %d\n", sc->use_msg); + device_printf(sc->dev, "Max targets: %d\n", sc->max_targets); device_printf(sc->dev, "REQ num pages: %d\n", sc->req_ring_num_pages); device_printf(sc->dev, "CMP num pages: %d\n", sc->cmp_ring_num_pages); device_printf(sc->dev, "MSG num pages: %d\n", sc->msg_ring_num_pages);