From owner-svn-src-all@FreeBSD.ORG Thu Nov 27 07:26:41 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D9922124; Thu, 27 Nov 2014 07:26:41 +0000 (UTC) Received: from mail-pd0-x232.google.com (mail-pd0-x232.google.com [IPv6:2607:f8b0:400e:c02::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A403F810; Thu, 27 Nov 2014 07:26:41 +0000 (UTC) Received: by mail-pd0-f178.google.com with SMTP id g10so4436726pdj.9 for ; Wed, 26 Nov 2014 23:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=stnCh7HPDx1MCzxXBs/XTjVuJhwxPD7FMgeqbgteins=; b=c01+dcKZkm/e/E+CwRLJ/J7cWdARdcIjaf1PINEAYxEv0V0S9XdI6Wt9o2/BRtldA/ kvAqBlaw/rH+yqXfBEZgGCRAaG9MNozPe5UqFDGD15mdf0G/EKrl1VPGm73VZqJzMHrC e/vDot2sNgi063aStLw2tKjzwp9VYca3tSd3REcxYmDmHxyYy/52xqpdEZ1VPN/SDN1g OZkjCbhwpO6kQLwxlv9OihDh7TAxjv7Zj5kyn9mge05LjPmiiPv53Aw+GSzkAGdqn0y2 bEp4nc8MjVwREXR4XtjMYkSuw4EWk9RAujpgVXC0vYsYXmcmD2XYkEP6l3zM2mMHxxkY ywkw== MIME-Version: 1.0 X-Received: by 10.70.23.99 with SMTP id l3mr60473942pdf.86.1417073201057; Wed, 26 Nov 2014 23:26:41 -0800 (PST) Sender: ermal.luci@gmail.com Received: by 10.70.91.232 with HTTP; Wed, 26 Nov 2014 23:26:40 -0800 (PST) In-Reply-To: <861torxt7j.fsf@nine.des.no> References: <201411191331.sAJDV9bH092190@svn.freebsd.org> <86tx1nvcy4.fsf@nine.des.no> <86ppcbvb04.fsf@nine.des.no> <86ioi3y0gb.fsf@nine.des.no> <861torxt7j.fsf@nine.des.no> Date: Thu, 27 Nov 2014 08:26:40 +0100 X-Google-Sender-Auth: QQhK8L8TIbPwmvvhfuPbQyPhQzs Message-ID: Subject: Re: svn commit: r274709 - head/sys/netpfil/pf From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 07:26:42 -0000 On Tue, Nov 25, 2014 at 3:14 PM, Dag-Erling Sm=C3=B8rgrav wrot= e: > Ermal Lu=C3=A7i writes: > > Also this only affects the traffic sourced by the host itself and not > > forwarded traffic and I think this patch will provide a regression for > > the issues that the committed patch does. > > How? > The code as it stands (after your commit) is incorrect and will trigger > an assertion in vtnet(4). You could argue that it is less incorrect > than the original, but the cure is worse than the disease. > > Let me come back to you in the following days with a better analysis. The existing sate of the world i think there will be checksum issues again especially in policy routing situations. I will come back with another patch to solve this, but am busy with some ${WORK} tasks. > My patch fixes the panic as well as two preexisting bugs (not taking the > IP checksum into account in the IPv4 path, and ignoring hardware > offloading). See https://bugs.freebsd.org/192013#c10 for an explanation > of what it does and why. > > DES > -- > Dag-Erling Sm=C3=B8rgrav - des@des.no > --=20 Ermal