From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 3 13:04:09 2006 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 478C116A407; Sun, 3 Dec 2006 13:04:09 +0000 (UTC) (envelope-from ruben@helium.verweg.com) Received: from helium.verweg.com (helium.xs4all.nl [194.109.251.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8FDC43CA6; Sun, 3 Dec 2006 13:03:41 +0000 (GMT) (envelope-from ruben@helium.verweg.com) Received: from helium.verweg.com (ruben@localhost.verweg.com [IPv6:::1]) by helium.verweg.com (8.13.8/8.13.8) with ESMTP id kB3D3wFL007458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 3 Dec 2006 14:04:03 +0100 (CET) (envelope-from ruben@helium.verweg.com) X-Authentication-Warning: helium.verweg.com: Host ruben@localhost.verweg.com [IPv6:::1] claimed to be helium.verweg.com Received: (from ruben@localhost) by helium.verweg.com (8.13.8/8.13.8/Submit) id kB3D3vwu007457; Sun, 3 Dec 2006 14:03:57 +0100 (CET) (envelope-from ruben) Date: Sun, 3 Dec 2006 14:03:57 +0100 From: Ruben van Staveren To: Pav Lucistnik Message-ID: <20061203130357.GA7338@helium.verweg.com> References: <200612021212.kB2CCYUL018259@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200612021212.kB2CCYUL018259@freefall.freebsd.org> X-LeerQuoten: http://leerquoten.verweg.com Organisation: Verweg Dot Com X-message: Zeker Outlook ? X-Opinion: These opinions are exclusively mine, you cannot have them. Patent pending. User-Agent: Mutt/1.5.13 (2006-08-11) X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=failed version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on helium.verweg.com X-Greylist: Sender is SPF-compliant, not delayed by milter-greylist-2.0.2 (helium.verweg.com [IPv6:::1]); Sun, 03 Dec 2006 14:04:06 +0100 (CET) Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/106203: linux-megacli needs unzip as a build dependancy too X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Dec 2006 13:04:09 -0000 On Sat, Dec 02, 2006 at 12:12:34PM +0000, Pav Lucistnik wrote: > Synopsis: linux-megacli needs unzip as a build dependancy too > > State-Changed-From-To: open->closed > State-Changed-By: pav > State-Changed-When: Sat Dec 2 12:10:40 UTC 2006 > State-Changed-Why: > Committed, thanks. I also added rpm2cpio as another build dependency, as I see > you use it in do-build: target too. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=106203 In light of Kris Kennaway's reply, maybe better have it like this. We can do it either now, or in the next version of megacli. Regards, Ruben --- Makefile.orig Sun Dec 3 12:41:31 2006 +++ Makefile Sun Dec 3 12:42:22 2006 @@ -15,8 +15,6 @@ MAINTAINER= ruben@verweg.com COMMENT= LSI MegaRAID SAS controller management utility -BUILD_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip - NO_WRKSUBDIR= yes USE_ZIP= yes RESTRICTED= Redistribution prohibited, see: http://lsi.com/cm/License.do @@ -28,10 +26,12 @@ RPM2CPIO?= ${LOCALBASE}/bin/rpm2cpio EXTRACT_DEPENDS+= ${RPM2CPIO}:${PORTSDIR}/archivers/rpm -do-build: +post-extract: @cd ${WRKSRC} && \ ${UNZIP_CMD} MegaCliLin.zip && \ ${RPM2CPIO} MegaCli-${PORTVERSION}-0.i386.rpm | ${CPIO} -id --quiet + +do-build: @${BRANDELF} -t Linux ${WRKSRC}/usr/sbin/MegaCli do-install: