From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Aug 7 09:50:04 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1B681065678 for ; Sat, 7 Aug 2010 09:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9B51B8FC1C for ; Sat, 7 Aug 2010 09:50:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o779o4ha061853 for ; Sat, 7 Aug 2010 09:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o779o49M061852; Sat, 7 Aug 2010 09:50:04 GMT (envelope-from gnats) Resent-Date: Sat, 7 Aug 2010 09:50:04 GMT Resent-Message-Id: <201008070950.o779o49M061852@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Timothy Beyer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1D6D1065673 for ; Sat, 7 Aug 2010 09:42:41 +0000 (UTC) (envelope-from beyert@fastmail.fm) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id C27018FC12 for ; Sat, 7 Aug 2010 09:42:41 +0000 (UTC) Received: from compute3.internal (compute3.internal [10.202.2.43]) by gateway1.messagingengine.com (Postfix) with ESMTP id 3249F190B7F; Sat, 7 Aug 2010 05:24:34 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute3.internal (MEProxy); Sat, 07 Aug 2010 05:24:34 -0400 Received: from aeonserv.aeonnet.fastmail.fm (cpe-76-90-217-240.socal.res.rr.com [76.90.217.240]) by mail.messagingengine.com (Postfix) with ESMTPSA id 3045F4FC361; Sat, 7 Aug 2010 05:24:33 -0400 (EDT) Message-Id: <87r5iapygh.wl@fastmail.fm> Date: Sat, 07 Aug 2010 02:24:30 -0700 From: Timothy Beyer To: FreeBSD-gnats-submit@FreeBSD.org Cc: Timothy Beyer Subject: ports/149391: fix for port: x11/mlterm X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Aug 2010 09:50:04 -0000 >Number: 149391 >Category: ports >Synopsis: fix for port: x11/mlterm >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Aug 07 09:50:04 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Timothy Beyer >Release: FreeBSD 8.0-RELEASE-p2 i386 >Organization: no organization >Environment: System: FreeBSD aeonserv.aeonnet 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Fri Jan 29 18:00:42 PST 2010 beyert@aeonserv.aeonnet:/usr/src/sys/i386/compile/CUSTOM i386 >Description: This patch prevents the following error from happening on my machine during compilation: /usr/bin/ld: cannot find -lutempter *** Error code 1 Stop in /usr/ports/x11/mlterm/work/mlterm-3.0.1/kiklib/src. In this problem report is a patch to the Makefile that turns off libtool and the CONFIGURE_ENV line, which fixed the build problem on my system. It also has two fewer warnings from portlint than the previous Makefile. I attempted to preserve as much of the previous design as possible, but I do not know if it preserves all of the features desired by the maintainer, particularly on 9-CURRENT. Also, this patch defaults to using --with-imagelib-gdk-pixbuf2 instead of --with-imagelib-gdk-pixbuf, and adds the --enable-optimize-redrawing switch. I think these are probably beneficial. >How-To-Repeat: Apply the patch >Fix: The included patch, --- Makefile.diff begins here --- --- Makefile.orig 2010-07-17 22:33:10.000000000 -0700 +++ Makefile 2010-08-07 01:42:58.000000000 -0700 @@ -15,16 +15,15 @@ LIB_DEPENDS= Xft.2:${PORTSDIR}/x11-fonts/libXft +HAS_CONFIGURE= yes USE_XORG= sm USE_GNOME= gtk20 lthack -USE_AUTOTOOLS= libtool:22 -LIBTOOLFILES= configure kiklib/configure mkf/configure USE_PERL5_BUILD=yes USE_GETTEXT= yes -CONFIGURE_ARGS= --with-imagelib=gdk-pixbuf --enable-utmp \ +CONFIGURE_ARGS= --with-imagelib=gdk-pixbuf2 --enable-utmp \ + --mandir="${LOCALBASE}/man" --enable-optimize-redrawing \ --with-tools="mlclient,mlconfig,mlterm-menu,mlcc,w3mmlconfig" \ --with-type-engines="xcore,xft" -CONFIGURE_ENV= LIBS="${LIBS} -L${LOCALBASE}/lib ${PTHREAD_LIBS} -lintl" CFLAGS="${CFLAGS} -I${LOCALBASE}/include -I${LOCALBASE}/include/iiim" MAKE_JOBS_UNSAFE= yes OPTIONS= FRIBIDI "Use Fribidi for BiDi rendering" off \ UIM "uim support (experimental)" off \ @@ -94,7 +93,6 @@ ${WRKSRC}/kiklib/configure ${WRKSRC}/mkf/configure post-configure: - @${CP} ${LIBTOOL} ${WRKSRC} @${REINPLACE_CMD} -e "s,@CGI_BIN@,${PREFIX}/libexec/w3mmlconfig," \ ${WRKSRC}/tool/w3mmlconfig/mlconfig.cgi .if ${OSVERSION} >= 900004 --- Makefile.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: