From owner-cvs-src@FreeBSD.ORG Tue Sep 30 17:13:59 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B94D106564A; Tue, 30 Sep 2008 17:13:59 +0000 (UTC) (envelope-from rik@inse.ru) Received: from mail.inse.ru (mail.inse.ru [144.206.128.1]) by mx1.freebsd.org (Postfix) with ESMTP id AEB428FC26; Tue, 30 Sep 2008 17:13:58 +0000 (UTC) (envelope-from rik@inse.ru) Received: from [127.0.0.1] (www.inse.ru [144.206.128.1]) by mail.inse.ru (Postfix) with ESMTPSA id 6B86933C53; Tue, 30 Sep 2008 21:13:54 +0400 (MSD) Message-ID: <48E25E51.5060502@inse.ru> Date: Tue, 30 Sep 2008 21:13:53 +0400 From: Roman Kurakin User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Roman Divacky References: <200809271014.m8RAENka041457@repoman.freebsd.org> <48DE5C4F.8040807@micom.mng.net> <48DF2010.6030309@micom.mng.net> <20080930162606.GA46594@freebsd.org> In-Reply-To: <20080930162606.GA46594@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Ganbold , src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2008 17:13:59 -0000 Roman Divacky wrote: > On Tue, Sep 30, 2008 at 05:19:57PM +0100, Robert Watson wrote: > >> On Sun, 28 Sep 2008, Ganbold wrote: >> >> >>>> Indeed -- when an inpcb doesn't have a socket, ipfw will go ahead and do >>>> a lookup for an inpcb even though one is passed down. I've committed a >>>> change that short-circuits that and marks the credential lookup as >>>> failed. Give it a try now? >>>> >>> Thanks a lot, Robert, it was indeed simple effective fix. So far no crash >>> :) With loads like pkg_adding emacs (which adds bunch of other packages) >>> on plain CURRENT, downloading FreeBSD ISO with axel (20 simultaneous >>> connection) through http works fine here. >>> >> Good news. We'll want to keep an eye on this one as the 7.0 release cycle >> progresses, and there may be other unexpected edge case problems from the >> rwlock change. On the whole it seems to have been very successful, but the >> view that -CURRENT doesn't receive a whole lot of stress testing is >> reinforced... >> > > I think this is a little different case... I guess people are willing to > test -CURRENT on their desktops etc. but not on "servers". ie. when you > have immediate access to the machine you easily use -CURRENT but not > on the remote server. > > Also, people don't tend to run firewalls on their desktops (as opposed to > servers where they dont). This is why I think this bug slipped. Not that > -CURRENT is so badly tested... > It looks that people are not so paranoid as they should be ... But probably they paranoid enough to not use the current ;-) rik > roman >