From owner-svn-src-all@freebsd.org Wed Apr 20 22:27:27 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D366B16F9A; Wed, 20 Apr 2016 22:27:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F11E10D9; Wed, 20 Apr 2016 22:27:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 064F7B918; Wed, 20 Apr 2016 18:27:26 -0400 (EDT) From: John Baldwin To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298377 - head/sys/dev/acpica Date: Wed, 20 Apr 2016 15:27:21 -0700 Message-ID: <2347008.OyWmM6azol@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201604202121.u3KLLllG091567@repo.freebsd.org> References: <201604202121.u3KLLllG091567@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 20 Apr 2016 18:27:26 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 22:27:27 -0000 On Wednesday, April 20, 2016 09:21:47 PM Jung-uk Kim wrote: > Author: jkim > Date: Wed Apr 20 21:21:47 2016 > New Revision: 298377 > URL: https://svnweb.freebsd.org/changeset/base/298377 > > Log: > Remove query flag from acpi_EvaluateOSC(). This function does not support > return buffer (yet). Hmm, I should probably fix that then instead? The PCI variant is (now) incorrectly assuming it gets the buffer back in the array it passed in. The 5.0 spec at least says that the returned values are identical in length to the array passed in. We could either add a new parameter for the outputs or copy them to the inputs. Perhaps the former is better? I'd still prefer to set caps[0] in the common code since it is not UUID-specific but something all _OSC callers have to do. -- John Baldwin