From nobody Sun May 3 14:24:48 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7n9V1RZvz6RgXf for ; Sun, 03 May 2026 14:25:02 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7n9S6M3Zz45DY for ; Sun, 03 May 2026 14:25:00 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; dkim=none ("invalid DKIM record") header.d=kev009.com header.s=google header.b=gMiLOAVA; dmarc=none; spf=pass (mx1.freebsd.org: domain of kevin.bowling@kev009.com designates 2607:f8b0:4864:20::82a as permitted sender) smtp.mailfrom=kevin.bowling@kev009.com; arc=pass ("google.com:s=arc-20240605:i=1") Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-5102582e23eso25807621cf.1 for ; Sun, 03 May 2026 07:25:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777818299; cv=none; d=google.com; s=arc-20240605; b=j2RYjgDa53hFflo6dwFew+frtmzf+zPueVflGmxDXasOMyWd66fiw+CJ5iNutbsjwl LJ7PSuL/w/RNKGwPgGyHxanv0PaSDAVK/1P3iaaaBFrZuSARMRztBVWpuqt+lrNT3Ay+ woEBRgLDBQTmaC4U0APTQAh5cj+nudL1FeMNakWJ9AC4xjf3otTQZrKHiIJ87bi9alx1 5fVdlpLulVx9FYHHpcCjK/CMa7dazdyxlCf/KIZVhicZK/cAZOrkIV2Kk1mYkhIofX3J wIGFQR7/8AMGa7vvw8ywGrIYjJOyOc7dzCzKVZZTH5JRlduAn2IxteTUpUWolfRRIMJH 9AZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ABLCh8+5cqk2/4gso/HTatGAHy3Aa/6V0RXiy8aCeVk=; fh=12IKZ2aKg/2bPgV8kZDBM7ZN2lFLx9Ibuha6HuyXbAE=; b=CoXY4gh0o0b3Q0T0/eayxvRCqlPVekh/XerlafJ0Figz5LDdL6FUz3x5ve+T3vNUMg vXyRNPydCNqZaaT+3XgYFGeWGwP8vwgbQ0NJFL52cRrfQ0EhfTov/uMPVIoU0AezVUS1 uFBldKUloY+Bkn380QAkhQt6nlaKfIEJM0PdJvU6rvXYE8bDymXP1zgnJr0msFrmE64E Qtcr7PvpSCl0B3kNO+e6j0gY2F0kLctT6LEn3ji6J8KOG6GQFAeBlyy9BpcpMXYvxyOO 8byCQR64F+p4hsoWsR2+xvZNWzCSQs/4qkPkhybnWJnhbqlj7+52lzwKYt2qB1IGuxh0 2TjA==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1777818299; x=1778423099; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ABLCh8+5cqk2/4gso/HTatGAHy3Aa/6V0RXiy8aCeVk=; b=gMiLOAVAIkZMJ6p45fkgivVW8P9brjOAhIoLCjohW4oGAMsqCdhiACblt3bIlV52aT qm3lfaeQ6uv5VWCn/kNYNGa4WzIi/M7KNWxwkwCDD0KsefkiqD3/R05psxvygfCnUkSf r7i6sbVWefEdpwQbL2pgNr25dr1ZvT6yl/Wsk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777818299; x=1778423099; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ABLCh8+5cqk2/4gso/HTatGAHy3Aa/6V0RXiy8aCeVk=; b=bL/KF/OGDT6Oa2ottD8rbhs3TbKF3bY9xX9A8yg0nwy9KMyAxGSwWLGb9s+MdSav5U CYLniLN78sfEcvBgbJi5yd688Il30P4wgnW4ZFDrPF7I0Q9P5YJWAu/0lM0TueJCnYWa kQSdDlES7pSjpBW88QahA1EDbY+og12ZM83VtUECknQAmuu4JZ0oODX0rKxVK303xP9I vFoJzETuRPdcgqKySl7kN9rWBq1128EJtycklmwuuDorv1Q3k+54HNXUJfWV+zm3Gfg4 wxyqa4XZu8m7coRfZtjwVO4xyJASBL4hPAY1VsbtMYAL8Fb2tDIhT1JV05hXreVulnMn m0Vg== X-Forwarded-Encrypted: i=1; AFNElJ/vLTrvhxVMo+iO3FcEWDtpMv2mSSuOFfZaVAxZ+DXgfuhX+arPYFhndP9QeAbB+4CDxvfWmtGnTbOOJMK50bMp5GZTXw==@freebsd.org X-Gm-Message-State: AOJu0YyaDXHRd2uKadNyeocrcMtxkztuRtrhAqA1J/T/GFE7QZaVNaqy f3CKNCycVFVQU2/+tGYpkDZWyWrmC6nr4u30G36Xp5gBpS3morjTYa/IYZLgqFoNRKYijUv25oA b3eP0g6LqtoOaniG5ydpAcADdJYOckrbeq6o3mB4S X-Gm-Gg: AeBDies9+/+cHhIh0q/tO31n4SBTbWpaVgzuZM7NhssQgwQIOlYUEWFrlowRMHuWFdD toolX4HsrVudC8zOStuxgyq77XJTAnd6Egwl93FRhf7fGXMoCJIIPFcSwHoqTNH3UlAXvAD1Q+O +fa68WsjPpLcV2inpwg984tNed1lVEM1zpUwAAgkXW9cDD/5XV0EsTNSTfLe3ooppDiDRuTusv/ +3oIkkZiPZBrTeExS5u8DlNdEFsYz6x1b3dbJUdl+PrNuq+oM7ZiBpbrwc2wkGub/fEaZaPXmkO A6BmzZ9j1FypbkAl9JX+HxZwqK3W8RWfeDpu7Fgx6FPGVNhZRHvuvTPEsnMbq7jfBfsPnvq2Hp7 dT/Uu91R++wFdGz11c1KpHBLzXrV6Ba9m2B1Nc5Sr9mLcumaf6PXHuhyrZgmW X-Received: by 2002:a05:622a:353:b0:50d:86d9:4c24 with SMTP id d75a77b69052e-5104bde6d9amr98724841cf.12.1777818299206; Sun, 03 May 2026 07:24:59 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <69f6b1ec.181e8.27d0b938@gitrepo.freebsd.org> In-Reply-To: From: Kevin Bowling Date: Sun, 3 May 2026 07:24:48 -0700 X-Gm-Features: AVHnY4IdiiYjGIPuDAoB64pRY6FyChlRIh6R7KSopVGPOEzXTO4afVx4Wi8JDwo Message-ID: Subject: Re: git: 01674e15dedb - main - bsd.endian.mk: Optimize the handling of big/little endian determination. To: "Stephen J. Kiernan" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-1.99 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_SHORT(-0.97)[-0.974]; NEURAL_SPAM_MEDIUM(0.43)[0.427]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56]; NEURAL_HAM_LONG(-0.14)[-0.139]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; R_DKIM_PERMFAIL(0.00)[kev009.com:s=google]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82a:from]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[kev009.com]; DKIM_TRACE(0.00)[kev009.com:~] X-Spamd-Bar: - X-Rspamd-Queue-Id: 4g7n9S6M3Zz45DY I think the issue is M_ListToSkip isn't defined in some contexts but I'm not sure why or where it might need to be set. It's not just the kmod that failed, another sample for analysis: =3D=3D=3D> Building for libcsv-3.0.3_4 make: /usr/share/mk/bsd.endian.mk:25: Unknown modifier ":aarch64 amd64 armv7 i386 powerpc64le riscv*" while evaluating indirect modifiers "aarch64 amd64 armv7 i386 powerpc64le riscv*" while evaluating variable "_ENDIAN_ARCH" with value "amd64" in /usr/share/mk/bsd.endian.mk:25 in .for loop from /usr/share/mk/bsd.compiler.mk:160 with cc =3D CC, X_ =3D ${_empty_var_} in /usr/share/mk/bsd.own.mk:297 in /usr/share/mk/bsd.init.mk:21 in /usr/share/mk/bsd.lib.mk:16 in /wrkdirs/usr/ports/textproc/libcsv/work/libcsv-3.0.3/Makefile.lib= :13 make: /usr/share/mk/bsd.endian.mk:53: Don't know the endianness of this architecture in .for loop from /usr/share/mk/bsd.compiler.mk:160 with cc =3D CC, X_ =3D ${_empty_var_} in /usr/share/mk/bsd.own.mk:297 in /usr/share/mk/bsd.init.mk:21 in /usr/share/mk/bsd.lib.mk:16 in /wrkdirs/usr/ports/textproc/libcsv/work/libcsv-3.0.3/Makefile.lib= :13 On Sun, May 3, 2026 at 5:51=E2=80=AFAM Kevin Bowling wrote: > > On Sat, May 2, 2026 at 7:24=E2=80=AFPM Stephen J. Kiernan wrote: > > > > The branch main has been updated by stevek: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D01674e15dedb15f8ce498af0= 680c50bb075c5482 > > > > commit 01674e15dedb15f8ce498af0680c50bb075c5482 > > Author: Stephen J. Kiernan > > AuthorDate: 2024-04-03 23:25:19 +0000 > > Commit: Stephen J. Kiernan > > CommitDate: 2026-05-03 02:21:56 +0000 > > > > bsd.endian.mk: Optimize the handling of big/little endian determina= tion. > > > > Add variables to contain lists of MACHINE_ARCH values to use > > to determine little or big endian. > > > > Only error out about not being able to determine endianess if > > TARGET_ENDIANNESS is empty and not cross-compiling. > > > > Reviewed by: sjg > > Obtained from: Hewlett Packard Enterprise Development LP > > Differential Revision: https://reviews.freebsd.org/D44629 > > --- > > share/mk/bsd.endian.mk | 39 +++++++++++++++++++++++++++++---------- > > 1 file changed, 29 insertions(+), 10 deletions(-) > > > > diff --git a/share/mk/bsd.endian.mk b/share/mk/bsd.endian.mk > > index 0c5ebb7aeba2..2a617a1d2794 100644 > > --- a/share/mk/bsd.endian.mk > > +++ b/share/mk/bsd.endian.mk > > @@ -1,20 +1,35 @@ > > > > -.if ${MACHINE_CPUARCH} =3D=3D "aarch64" || \ > > - ${MACHINE_CPUARCH} =3D=3D "arm" || \ > > - ${MACHINE_ARCH} =3D=3D "amd64" || \ > > - ${MACHINE_ARCH} =3D=3D "i386" || \ > > - ${MACHINE_ARCH} =3D=3D "powerpc64le" || \ > > - ${MACHINE_CPUARCH} =3D=3D "riscv" > > +MACHINE_ARCH_LIST.little =3D \ > > + aarch64 \ > > + amd64 \ > > + armv7 \ > > + i386 \ > > + powerpc64le \ > > + riscv* > > + > > +MACHINE_ARCH_LIST.big =3D \ > > + powerpc \ > > + powerpc64 > > + > > +.for e in big little > > +N_$e:=3D ${MACHINE_ARCH_LIST.$e:${M_ListToSkip}} > > +.endfor > > + > > +# For the host, we need to look at the host architecture > > +.if ${MACHINE:Nhost*} =3D=3D "" > > +_ENDIAN_ARCH=3D${_HOST_ARCH} > > +.else > > +_ENDIAN_ARCH=3D${MACHINE_ARCH} > > +.endif > > + > > +.if ${_ENDIAN_ARCH:${N_little}} =3D=3D "" > > TARGET_ENDIANNESS=3D 1234 > > CAP_MKDB_ENDIAN=3D -l > > LOCALEDEF_ENDIAN=3D -l > > -.elif ${MACHINE_ARCH} =3D=3D "powerpc" || \ > > - ${MACHINE_ARCH} =3D=3D "powerpc64" > > +.elif ${_ENDIAN_ARCH:${N_big}} =3D=3D "" > > TARGET_ENDIANNESS=3D 4321 > > CAP_MKDB_ENDIAN=3D -b > > LOCALEDEF_ENDIAN=3D -b > > -.elif ${.MAKE.OS} =3D=3D "FreeBSD" > > -.error Don't know the endian of this architecture > > .else > > # > > # During bootstrapping on !FreeBSD OSes, we need to define some value.= Short of > > @@ -33,3 +48,7 @@ TARGET_ENDIANNESS=3D 1234 > > CAP_MKDB_ENDIAN=3D -B # Poisoned value, invalid flags for both cap_= mkdb > > LOCALEDEF_ENDIAN=3D -B # and localedef. > > .endif > > + > > +.if empty(TARGET_ENDIANNESS) && ${.MAKE.OS} =3D=3D "FreeBSD" > > +.error Don't know the endianness of this architecture > > +.endif > > This might be breaking poudriere pkg builds i.e. graphics/drm-66-kmod: > > make[1]: /usr/share/mk/bsd.endian.mk:25: Unknown modifier ":aarch64 > amd64 armv7 i386 powerpc64le riscv*" > while evaluating indirect modifiers "aarch64 amd64 armv7 > i386 powerpc64le riscv*" > while evaluating variable "_ENDIAN_ARCH" with value "amd64" > in /usr/share/mk/bsd.endian.mk:25 > in .for loop from /usr/share/mk/bsd.compiler.mk:160 with cc =3D > CC, X_ =3D ${_empty_var_} > in /usr/share/mk/bsd.own.mk:297 > in /usr/share/mk/bsd.init.mk:21 > in /usr/src/sys/conf/kern.opts.mk:21 > in /wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.= 25_10/Makefile:4 > in make[1] in directory > "/wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25_10" > make[1]: /usr/share/mk/bsd.endian.mk:53: Don't know the endianness of > this architecture > in .for loop from /usr/share/mk/bsd.compiler.mk:160 with cc =3D > CC, X_ =3D ${_empty_var_} > in /usr/share/mk/bsd.own.mk:297 > in /usr/share/mk/bsd.init.mk:21 > in /usr/src/sys/conf/kern.opts.mk:21 > in /wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.= 25_10/Makefile:4 > in make[1] in directory > "/wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25_10" > > make[1]: stopped making "obj" in > /wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25_10 > *** Error code 1