From owner-freebsd-current Mon Mar 18 10:24:33 2002 Delivered-To: freebsd-current@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id D5FED37B428 for ; Mon, 18 Mar 2002 10:24:05 -0800 (PST) Received: (qmail 25834 invoked from network); 18 Mar 2002 18:24:03 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 18 Mar 2002 18:24:03 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2IIOTv53740; Mon, 18 Mar 2002 13:24:30 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Mon, 18 Mar 2002 13:24:04 -0500 (EST) From: John Baldwin To: Robert Watson Subject: Re: -current lock warning... Cc: smp@FreeBSD.ORG, current@FreeBSD.ORG, hitmaster2k@yahoo.com, phk@FreeBSD.ORG, tanimura@r.dl.itc.u-tokyo.ac.jp, Munehiro Matsuda , Alfred Perlstein Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 17-Mar-2002 Robert Watson wrote: > > On Sun, 17 Mar 2002, Alfred Perlstein wrote: > >> * Munehiro Matsuda [020317 06:36] wrote: >> > >> > PS. I got another message that happend when I ^C'ed a buildworld earlier, >> > with same kernel. May be it should go to Alfred Perlstein? >> > >> > lock order reversal >> > 1st 0xc198eec0 pipe mutex @ ../../../kern/sys_pipe.c:779 >> > 2nd 0xc0367fe0 Giant @ ../../../i386/i386/trap.c:716 >> >> I think there's a place where the pipe can fault on an address while >> copying, I'll take a look at this. > > Are there any assertions that should be in place for copyin/copyout > requring fault handling? It sounds like somewhere we need to assert that > Giant is held... More correct is that probably no locks other than Giant should be held for copyin/copyout. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message