From owner-freebsd-threads@FreeBSD.ORG  Mon Jun  5 00:30:47 2006
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
X-Original-To: freebsd-threads@hub.freebsd.org
Delivered-To: freebsd-threads@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 575E416A75F;
	Mon,  5 Jun 2006 00:30:47 +0000 (UTC)
	(envelope-from rodrigc@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0C05043D45;
	Mon,  5 Jun 2006 00:30:47 +0000 (GMT)
	(envelope-from rodrigc@FreeBSD.org)
Received: from freefall.freebsd.org (rodrigc@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k550UkGF072026;
	Mon, 5 Jun 2006 00:30:46 GMT
	(envelope-from rodrigc@freefall.freebsd.org)
Received: (from rodrigc@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k550UkcC072022;
	Mon, 5 Jun 2006 00:30:46 GMT (envelope-from rodrigc)
Date: Mon, 5 Jun 2006 00:30:46 GMT
From: Craig Rodrigues <rodrigc@FreeBSD.org>
Message-Id: <200606050030.k550UkcC072022@freefall.freebsd.org>
To: earl_chew@agilent.com, rodrigc@FreeBSD.org, freebsd-threads@FreeBSD.org
Cc: 
Subject: Re: kern/24641: pthread_rwlock_rdlock can deadlock
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jun 2006 00:30:48 -0000

Synopsis: pthread_rwlock_rdlock can deadlock

State-Changed-From-To: open->closed
State-Changed-By: rodrigc
State-Changed-When: Mon Jun 5 00:28:27 UTC 2006
State-Changed-Why: 
Problem does not occur in libpthread in FreeBSD 6.x.

Your testcase needs to be modified slightly.
If you call pthread_join(),
then if you call pthread_detach() later on, pthread_detach
may return EINVAL, because the thread may already be
terminated and detached, so you can't detach it.


#include <pthread.h>
#include <stdio.h>
#include <unistd.h>
#include <assert.h>
#include <errno.h>
 
 static pthread_rwlock_t rwlock1 = PTHREAD_RWLOCK_INITIALIZER;
 
 static volatile int wrStarted;
 
 void * wrfunc(void *unused)
 {
    wrStarted = 1;

    printf("Attempt to acquire write lock\n");
    assert(pthread_rwlock_wrlock(&rwlock1) == 0);
    printf("Acquired write lock\n");
 
    assert(pthread_rwlock_unlock(&rwlock1) == 0);

    return 0;
 }
 
 static volatile int rdStarted;
 
 void * rdfunc(void *unused)
 {
    printf("Attempt to acquire read lock first\n");

    assert(pthread_rwlock_rdlock(&rwlock1) == 0);
    printf("Acquired read lock first\n");

    rdStarted = 1;

    while (wrStarted == 0)
        sleep(1);
 
    printf("Attempt to acquire read lock second\n");
    assert(pthread_rwlock_rdlock(&rwlock1) == 0);
    printf("Acquired read lock second\n");
 
    assert(pthread_rwlock_unlock(&rwlock1) == 0);
    assert(pthread_rwlock_unlock(&rwlock1) == 0);

    return 0;
 }
 
 int
 main(int argc, char **argv)
 {
    pthread_t wrt;
    pthread_t rdt;
    pthread_attr_t a;
    int ret;
 
    assert(pthread_rwlock_init(&rwlock1, 0) == 0);
 
    assert(pthread_attr_init(&a) == 0);
 
    assert(pthread_create(&rdt, &a, rdfunc, NULL) == 0);
 
    while (rdStarted == 0)
        sleep(1);
 
    assert(pthread_create(&wrt, &a, wrfunc, NULL) == 0);
 
   assert(pthread_join(wrt, 0) == 0);
   assert(pthread_join(rdt, 0) == 0);
 
    assert(pthread_rwlock_destroy(&rwlock1) == 0);
 
   if ((ret = pthread_detach(wrt)) != 0) {
	if (ret == EINVAL) {
		printf("wrt already detached\n");
	}
   }

  if ((ret = pthread_detach(rdt)) != 0) {
	if (errno == EINVAL) {
		printf("rdt already detached\n");
	}
  } 
    return 0;
 }
 

http://www.freebsd.org/cgi/query-pr.cgi?pr=24641