From owner-cvs-all Thu Feb 6 16:16:58 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3C2B37B401; Thu, 6 Feb 2003 16:16:56 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 099BE43F75; Thu, 6 Feb 2003 16:16:56 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.6/8.12.5) with SMTP id h170GdP4052417; Thu, 6 Feb 2003 19:16:39 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Thu, 6 Feb 2003 19:16:39 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Scott Long Cc: all-committers@FreeBSD.org, legacy-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mly mly.c mlyvar.h In-Reply-To: <200302062346.h16NkWQu088537@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Wonderful, thanks for looking into this! I'm very pleased to have it off the "known broken for 5.0" list. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Thu, 6 Feb 2003, Scott Long wrote: > scottl 2003/02/06 15:46:32 PST > > Modified files: > sys/dev/mly mly.c mlyvar.h > Log: > Fix the mly driver! If card resources became unavailable, the driver would > correctly tell CAM to requeue the command and then freeze it's queue. The > problem was that when resources became available again, it wouldn't tell > CAM to unfreeze it's queue, so no more commands would ever be delivered. > This is simialr to the bug that was fixed in the cciss driver last year. > This is a bug in 4-STABLE also, but is probably masked by the OS being > fast enough to drain the completion queue before it fills up. > Also add some diagnostics avaialble when compiled with MLY_DEBUG. > Thanks very much to LSI Corp for donating equipment to track this down, > and Vaidus Damosevicius for pestering me long enough to get it fixed. > > Revision Changes Path > 1.20 +46 -0 src/sys/dev/mly/mly.c > 1.5 +2 -0 src/sys/dev/mly/mlyvar.h > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message