From owner-svn-src-head@freebsd.org Sun Aug 9 07:37:20 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA73399D970 for ; Sun, 9 Aug 2015 07:37:20 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E7BA11E for ; Sun, 9 Aug 2015 07:37:19 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by oio137 with SMTP id 137so71813421oio.0 for ; Sun, 09 Aug 2015 00:37:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=HyKDJIOxy0sYx6DumwhtC6Gh78S5pmBM8ZtSMOk4f00=; b=VbPw3eoa67D+mhbVUjjuGdfndHK3ypApb64BvclX7RSLC9B8kLwfcv9Gf289/pJBnA pwylozuD9YgTd8i5KZsj6Z5eVZG+eoiWiVWKJLDD2w42r8rq/m9q2Lc5VZ9B8AfKhFS3 yjyk8vdD7SB4dZ4JflO/FpPm1gqJ+WpoeLlc2r0uaV2nylVLuV82QJQhkURVFBCJjSN6 U4gHAc7GlVXSWrXVo1hefseMSZAQ7zSiMJUFz60Ks2wEWjrA2NhZBzD3aGpVxz/7cYDf 3Tonu0BPT8/sYd35ustGo/Q7bI0EgMU27IJrfNQePJAnMd92dnh89y1yTl9kvw6sse8+ dtmw== X-Gm-Message-State: ALoCoQl57Dsrf8oL0+GOOM7mk8Bwv8Op9o1OTttdOX/vVi+tM5zJSXM4+NohAiTefQxOoH8LqwOY MIME-Version: 1.0 X-Received: by 10.202.171.21 with SMTP id u21mr13803275oie.113.1439105833199; Sun, 09 Aug 2015 00:37:13 -0700 (PDT) Received: by 10.76.50.84 with HTTP; Sun, 9 Aug 2015 00:37:13 -0700 (PDT) X-Originating-IP: [84.27.222.46] In-Reply-To: <20150808150539.0b43cfcd@kan> References: <201507271317.t6RDHwpj067194@repo.freebsd.org> <20150808150539.0b43cfcd@kan> Date: Sun, 9 Aug 2015 09:37:13 +0200 Message-ID: Subject: Re: svn commit: r285910 - in head: lib/libc/sys sys/kern sys/sys From: Ed Schouten To: Alexander Kabaev Cc: Ed Schouten , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: multipart/mixed; boundary=001a113cae68fbad7c051cdbef59 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Aug 2015 07:37:20 -0000 --001a113cae68fbad7c051cdbef59 Content-Type: text/plain; charset=UTF-8 Hi Alexander, 2015-08-08 21:05 GMT+02:00 Alexander Kabaev : > this commit broke more than just syslogd. rtsol and rtsold both are > victims of the change as they are trying to shutdown unconnected > raw sockets to make then 'send-only' and fail. Good catch! I think that in this case it is safe to omit the call to shutdown(), or at least not let the application fail on startup because of shutdown() being more strict. After all, this code would fail on Linux, OS X, etc. already because of this. Could you test the attached patch and let me know whether it makes rtsol/rtsold work again? Thanks, -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK/VAT number: 62051717 --001a113cae68fbad7c051cdbef59 Content-Type: text/plain; charset=US-ASCII; name="rtsold.diff" Content-Disposition: attachment; filename="rtsold.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_id46gcon1 ZGlmZiAtLWdpdCBhL3Vzci5zYmluL3J0c29sZC9wcm9iZS5jIGIvdXNyLnNiaW4vcnRzb2xkL3By b2JlLmMKaW5kZXggODlhMTYxN2EuLjNhYTUzMDMgMTAwNjQ0Ci0tLSBhL3Vzci5zYmluL3J0c29s ZC9wcm9iZS5jCisrKyBiL3Vzci5zYmluL3J0c29sZC9wcm9iZS5jCkBAIC04MCwxMiArODAsNiBA QCBwcm9iZV9pbml0KHZvaWQpCiAJCXJldHVybiAoLTEpOwogCX0KIAotCS8qIG1ha2UgdGhlIHNv Y2tldCBzZW5kLW9ubHkgKi8KLQlpZiAoc2h1dGRvd24ocHJvYmVzb2NrLCAwKSkgewotCQl3YXJu bXNnKExPR19FUlIsIF9fZnVuY19fLCAic2h1dGRvd246ICVzIiwgc3RyZXJyb3IoZXJybm8pKTsK LQkJcmV0dXJuICgtMSk7Ci0JfQotCiAJLyogaW5pdGlhbGl6ZSBtc2doZHIgZm9yIHNlbmRpbmcg cGFja2V0cyAqLwogCXNuZG1oZHIubXNnX25hbWVsZW4gPSBzaXplb2Yoc3RydWN0IHNvY2thZGRy X2luNik7CiAJc25kbWhkci5tc2dfaW92ID0gc25kaW92Owo= --001a113cae68fbad7c051cdbef59--