From owner-freebsd-questions@FreeBSD.ORG Sat Jan 28 20:35:28 2006 Return-Path: X-Original-To: freebsd-questions@freebsd.org Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50DA516A420; Sat, 28 Jan 2006 20:35:28 +0000 (GMT) (envelope-from stijn@pcwin002.win.tue.nl) Received: from kweetal.tue.nl (kweetal.tue.nl [131.155.3.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66B7643D55; Sat, 28 Jan 2006 20:35:27 +0000 (GMT) (envelope-from stijn@pcwin002.win.tue.nl) Received: from localhost (localhost [127.0.0.1]) by kweetal.tue.nl (Postfix) with ESMTP id F34E313B730; Sat, 28 Jan 2006 21:35:25 +0100 (CET) Received: from kweetal.tue.nl ([127.0.0.1]) by localhost (kweetal.tue.nl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83142-10; Sat, 28 Jan 2006 21:35:25 +0100 (CET) Received: from umta.win.tue.nl (umta.win.tue.nl [131.155.71.100]) by kweetal.tue.nl (Postfix) with ESMTP id 1B58B13B715; Sat, 28 Jan 2006 21:35:25 +0100 (CET) Received: from pcwin002.win.tue.nl (pcwin002 [131.155.71.72]) by umta.win.tue.nl (Postfix) with ESMTP id 09AC431401C; Sat, 28 Jan 2006 21:35:25 +0100 (CET) Received: by pcwin002.win.tue.nl (Postfix, from userid 1001) id F0A5C4124; Sat, 28 Jan 2006 21:35:24 +0100 (CET) Date: Sat, 28 Jan 2006 21:35:24 +0100 From: Stijn Hoop To: Anish Mistry , Mark Kane , gnome@freebsd.org, Frank Staals , freebsd-questions@freebsd.org, Simon Barner Message-ID: <20060128203524.GB68709@pcwin002.win.tue.nl> Mail-Followup-To: Stijn Hoop , Anish Mistry , Mark Kane , gnome@freebsd.org, Frank Staals , freebsd-questions@freebsd.org, Simon Barner References: <200601271218.00377.mistry.7@osu.edu> <43DA7946.6000100@mkproductions.org> <200601271850.21187.mistry.7@osu.edu> <20060128163501.GA68709@pcwin002.win.tue.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline In-Reply-To: <20060128163501.GA68709@pcwin002.win.tue.nl> User-Agent: Mutt/1.4.2.1i X-Bright-Idea: Let's abolish HTML mail! X-Virus-Scanned: amavisd-new at tue.nl X-Mailman-Approved-At: Sat, 28 Jan 2006 20:58:10 +0000 Cc: Subject: Re: Firefox 1.5 X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2006 20:35:28 -0000 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable For those interested, paste the inline patch below in /usr/ports/www/firefox/files/patch-bugzilla305970 And reinstall your firefox. Thanks again, Anish, it certainly seemed to help me! --Stijn --- widget/src/gtk2/nsWindow.cpp.orig Thu Aug 18 10:11:23 2005 +++ widget/src/gtk2/nsWindow.cpp Sat Jan 28 18:34:03 2006 @@ -148,9 +148,9 @@ GdkEventVisibility *event); static gboolean window_state_event_cb (GtkWidget *widget, GdkEventWindowState *event); -static void style_set_cb (GtkWidget *widget, - GtkStyle *previous_style, - gpointer data); +static void theme_changed_cb (GtkSettings *settings, + GParamSpec *pspec, + nsWindow *data); #ifdef __cplusplus extern "C" { #endif /* __cplusplus */ @@ -372,6 +372,10 @@ mIsDestroyed =3D PR_TRUE; mCreated =3D PR_FALSE; =20 + g_signal_handlers_disconnect_by_func(gtk_settings_get_default(), + (gpointer)G_CALLBACK(theme_change= d_cb), + this); + // ungrab if required nsCOMPtr rollupWidget =3D do_QueryReferent(gRollupWindow); if (NS_STATIC_CAST(nsIWidget *, this) =3D=3D rollupWidget.get()) { @@ -2434,8 +2438,16 @@ G_CALLBACK(delete_event_cb), NULL); g_signal_connect(G_OBJECT(mShell), "window_state_event", G_CALLBACK(window_state_event_cb), NULL); - g_signal_connect(G_OBJECT(mShell), "style_set", - G_CALLBACK(style_set_cb), NULL); + + g_signal_connect_after(gtk_settings_get_default(), + "notify::gtk-theme-name", + G_CALLBACK(theme_changed_cb), this); + g_signal_connect_after(gtk_settings_get_default(), + "notify::gtk-key-theme-name", + G_CALLBACK(theme_changed_cb), this); + g_signal_connect_after(gtk_settings_get_default(), + "notify::gtk-font-name", + G_CALLBACK(theme_changed_cb), this); } =20 if (mContainer) { @@ -3916,11 +3928,9 @@ =20 /* static */ void -style_set_cb (GtkWidget *widget, GtkStyle *previous_style, gpointer data) +theme_changed_cb (GtkSettings *settings, GParamSpec *pspec, nsWindow *data) { - nsWindow *window =3D get_window_for_gtk_widget(widget); - if (window) - window->ThemeChanged(); + data->ThemeChanged(); } =20 ////////////////////////////////////////////////////////////////////// --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD29WMY3r/tLQmfWcRAvdxAKCZaMrrTvzViiC8C8C+kHosFDYinACgt2Gi vXoM9JW2WvS4c4oCYl9ymeY= =NW82 -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY--