From owner-freebsd-ports@FreeBSD.ORG  Wed Feb 27 08:05:01 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 20B32A23;
 Wed, 27 Feb 2013 08:05:01 +0000 (UTC) (envelope-from stb@lassitu.de)
Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2a00:14b0:4200:32e0::1ea])
 by mx1.freebsd.org (Postfix) with ESMTP id D683EF72;
 Wed, 27 Feb 2013 08:05:00 +0000 (UTC)
Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 8FA00A0225;
 Wed, 27 Feb 2013 08:04:59 +0000 (UTC)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: pam_ssh_agent_auth: ENOENT
From: Stefan Bethke <stb@lassitu.de>
In-Reply-To: <512DBD48.4080100@andric.com>
Date: Wed, 27 Feb 2013 09:04:59 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <830CEF08-04B2-40C6-BAD6-B2C738BD9536@lassitu.de>
References: <CA+7WWSfx0viznxyjueEjVjgWzXLy6wqsv+kjMaW2Cp98y3yV4g@mail.gmail.com>
 <CA+7WWSdS-QMgLz4cyPJbjC_yAn4CWvpKwCbKcpR4HxrznGos=w@mail.gmail.com>
 <7A12B6B7-BE3F-4E0A-99C5-61348CA7E028@lassitu.de>
 <B9524981-A0C5-417C-BD53-CD658BE59E09@lassitu.de>
 <CA+7WWSdy_KxXRX2zVyPU6-F5uwpNTwEYsNnVvpEOYw+rXzvpLw@mail.gmail.com>
 <6C2D19D2-A599-4B6A-89CC-D32DF685926F@lassitu.de>
 <CA+7WWSeFjDU=XFan8mocpRy0V3DYxOyz1Zznju0PEdGjNR0OHw@mail.gmail.com>
 <719342CC-0D44-405C-A51B-532D8AB04774@lassitu.de>
 <512DBD48.4080100@andric.com>
To: Dimitry Andric <dimitry@andric.com>, "miwi@freebsd.org" <miwi@freebsd.org>
X-Mailer: Apple Mail (2.1499)
Cc: Muhammad Moinur Rahman <5u623l20@gmail.com>,
 Kimmo Paasiala <kpaasial@gmail.com>, Brooks Davis <brooks@freebsd.org>,
 Constantin Stefanov <cstef@parallel.ru>, freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Feb 2013 08:05:01 -0000


Am 27.02.2013 um 09:01 schrieb Dimitry Andric <dimitry@andric.com>:

> On 2013-02-27 00:39, Stefan Bethke wrote:
> ...
>> openbsd-compat/vis.h is #ifdef'd HAVE_STRNVIS, so we check configure. =
 configure.log thinks we have a suitable strnvis:
>>=20
>> configure:16566: checking for strnvis
>> configure:16622: cc -o conftest -O2 -pipe -fno-strict-aliasing -fPIC =
-Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign =
-fstack-protector-all   -fstack-protector-all conftest.c  -lutil -lpam =
>&5
>> configure:16629: $? =3D 0
>> configure:16651: result: yes
>>=20
>>=20
>> Do we?
>=20
> We have strnvis(), but it is not suitable.  We got strnvis() from
> NetBSD, and its arguments are in a different order from OpenBSD's
> version.  See the archive for earlier discussions (and crash reports =
:)
> about this.
>=20
> I recommend adding the line:
>=20
> CONFIGURE_ENV=3D		ac_cv_func_strnvis=3Dno
>=20
> to the port Makefile, just as with security/openssh-portable.

Ah, neat, I didn't know you could do that in a Makefile.  I've just =
submitted ports/176469 with a patch to configure, but this much nicer.

http://www.freebsd.org/cgi/query-pr.cgi?pr=3D176469


Stefan

--=20
Stefan Bethke <stb@lassitu.de>   Fon +49 151 14070811