From owner-svn-src-all@freebsd.org Sun Mar 10 17:08:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20126153A077; Sun, 10 Mar 2019 17:08:06 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B76CF85450; Sun, 10 Mar 2019 17:08:05 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A7D63261A9; Sun, 10 Mar 2019 17:08:05 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x2AH85nm028755; Sun, 10 Mar 2019 17:08:05 GMT (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x2AH85Eo028754; Sun, 10 Mar 2019 17:08:05 GMT (envelope-from glebius@FreeBSD.org) Message-Id: <201903101708.x2AH85Eo028754@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: glebius set sender to glebius@FreeBSD.org using -f From: Gleb Smirnoff Date: Sun, 10 Mar 2019 17:08:05 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r344979 - head/sys/net X-SVN-Group: head X-SVN-Commit-Author: glebius X-SVN-Commit-Paths: head/sys/net X-SVN-Commit-Revision: 344979 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B76CF85450 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.95 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.953,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Mar 2019 17:08:06 -0000 Author: glebius Date: Sun Mar 10 17:08:05 2019 New Revision: 344979 URL: https://svnweb.freebsd.org/changeset/base/344979 Log: Properly handle a case when a first filter returns PFIL_REALLOCED, then second one returns PFIL_PASS. Modified: head/sys/net/pfil.c Modified: head/sys/net/pfil.c ============================================================================== --- head/sys/net/pfil.c Sun Mar 10 16:14:42 2019 (r344978) +++ head/sys/net/pfil.c Sun Mar 10 17:08:05 2019 (r344979) @@ -154,7 +154,8 @@ pfil_run_hooks(struct pfil_head *head, pfil_packet_t p struct epoch_tracker et; pfil_chain_t *pch; struct pfil_link *link; - pfil_return_t rv, rvi; + pfil_return_t rv; + bool realloc = false; if (PFIL_DIR(flags) == PFIL_IN) pch = &head->head_in; @@ -167,21 +168,22 @@ pfil_run_hooks(struct pfil_head *head, pfil_packet_t p PFIL_EPOCH_ENTER(et); CK_STAILQ_FOREACH(link, pch, link_chain) { if ((flags & PFIL_MEMPTR) && !(link->link_flags & PFIL_MEMPTR)) - rvi = pfil_fake_mbuf(link->link_func, p.mem, ifp, + rv = pfil_fake_mbuf(link->link_func, p.mem, ifp, flags, link->link_ruleset, inp); else - rvi = (*link->link_func)(p, ifp, flags, + rv = (*link->link_func)(p, ifp, flags, link->link_ruleset, inp); - if (rvi == PFIL_DROPPED || rvi == PFIL_CONSUMED) { - rv = rvi; + if (rv == PFIL_DROPPED || rv == PFIL_CONSUMED) break; - } else if (rv == PFIL_REALLOCED) { + else if (rv == PFIL_REALLOCED) { flags &= ~(PFIL_MEMPTR | PFIL_LENMASK); - rv = rvi; + realloc = true; } } PFIL_EPOCH_EXIT(et); - return (rvi); + if (realloc && rv == PFIL_PASS) + rv = PFIL_REALLOCED; + return (rv); } /*