From owner-svn-src-all@freebsd.org Sun Apr 2 13:36:57 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F372BD2AA3A; Sun, 2 Apr 2017 13:36:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7096EC06; Sun, 2 Apr 2017 13:36:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v32Dape7082881 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 2 Apr 2017 16:36:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v32Dape7082881 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v32Daphd082880; Sun, 2 Apr 2017 16:36:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 2 Apr 2017 16:36:51 +0300 From: Konstantin Belousov To: Dmitry Chagin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316393 - head/sys/compat/linux Message-ID: <20170402133651.GJ43712@kib.kiev.ua> References: <201704020746.v327kDSN042840@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704020746.v327kDSN042840@repo.freebsd.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Apr 2017 13:36:58 -0000 On Sun, Apr 02, 2017 at 07:46:13AM +0000, Dmitry Chagin wrote: > Author: dchagin > Date: Sun Apr 2 07:46:13 2017 > New Revision: 316393 > URL: https://svnweb.freebsd.org/changeset/base/316393 > > Log: > As noted by bde@ negative tv_sec values are not checked for overflow, > so overflow can still occur. Fix that. Also remove the extra check for > tv_sec size as under COMPAT_LINUX32 it is always true. > > Pointed out by: bde@ > > MFC after: 1 week > > Modified: > head/sys/compat/linux/linux_time.c > > Modified: head/sys/compat/linux/linux_time.c > ============================================================================== > --- head/sys/compat/linux/linux_time.c Sun Apr 2 07:11:15 2017 (r316392) > +++ head/sys/compat/linux/linux_time.c Sun Apr 2 07:46:13 2017 (r316393) > @@ -125,8 +125,7 @@ native_to_linux_timespec(struct l_timesp > > LIN_SDT_PROBE2(time, native_to_linux_timespec, entry, ltp, ntp); > #ifdef COMPAT_LINUX32 > - if (ntp->tv_sec > INT_MAX && > - sizeof(ltp->tv_sec) != sizeof(ntp->tv_sec)) > + if (ntp->tv_sec > INT_MAX || ntp->tv_sec < INT_MIN) This line reads as only tv_sec == INT_MAX case results in non-EOVERFLOW condition. > return (EOVERFLOW); > #endif > ltp->tv_sec = ntp->tv_sec;