From owner-svn-ports-all@freebsd.org Thu Aug 13 14:23:55 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 82E7037B50A; Thu, 13 Aug 2020 14:23:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BS82M2skrz4MN7; Thu, 13 Aug 2020 14:23:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 409C31517D; Thu, 13 Aug 2020 14:23:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f172.google.com with SMTP id c12so4448148qtn.9; Thu, 13 Aug 2020 07:23:55 -0700 (PDT) X-Gm-Message-State: AOAM531cjWJURI8PpGOs/VavwsxGAeoJX2RYOTrdZjaR02yM4sDI0KZt 00xnN6rFatAPKItSMV9Zqjgu7H1Cl5s9iXKClyE= X-Google-Smtp-Source: ABdhPJzQCYJNAVGMJpkwlxQPII5anunE5UqgBc+d8IjL8IBTKa/gpG4VmFzdFr1Og3gYJlGYH+ApWiN03xdDEyKYfiE= X-Received: by 2002:ac8:7a66:: with SMTP id w6mr5680386qtt.242.1597328634822; Thu, 13 Aug 2020 07:23:54 -0700 (PDT) MIME-Version: 1.0 References: <202008112225.07BMPKiU025312@repo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Thu, 13 Aug 2020 09:23:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r544720 - head/sysutils/openzfs-kmod To: Alan Somers Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 14:23:55 -0000 On Wed, Aug 12, 2020 at 8:09 AM Alan Somers wrote: > > On Wed, Aug 12, 2020 at 6:54 AM Kyle Evans wrote: >> >> On Tue, Aug 11, 2020 at 5:25 PM Alan Somers wrote: >> > >> > Author: asomers (src committer) >> > Date: Tue Aug 11 22:25:20 2020 >> > New Revision: 544720 >> > URL: https://svnweb.freebsd.org/changeset/ports/544720 >> > >> > Log: >> > sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE >> > >> > ports that need FreeBSD's src code should check $SRC_BASE rather than assume >> > /usr/src. For example, it should be possible to build openzfs-kmod with a >> > command like this: >> > >> > env SRC_BASE=$HOME/freebsd/base/head make >> > >> > Approved by: freqlabs (maintainer) >> > MFH: 2020Q3 >> > Sponsored by: Axcient >> > Differential Revision: https://reviews.freebsd.org/D26033 >> > >> >> For future reference, this actually needed additional approval for the >> commit to ports, since neither you nor freqlabs are ports committers. >> This commit looks fine to me and I don't reckon you need to do >> anything with this information for now, though. >> >> Thanks, >> >> Kyle Evans > > > Sorry. brd previously told me that maintainer approval was sufficient for changes like this. > -Alan Ah, ok, so this makes sense- to clarify, this statement is true if it's qualified with 'assuming the maintainer is a ports committer'. You wouldn't need to seek out a second ports committer if the maintainer is already one and approves of the change.