From owner-freebsd-usb@FreeBSD.ORG Wed Aug 20 06:08:42 2008 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BA841065674; Wed, 20 Aug 2008 06:08:42 +0000 (UTC) (envelope-from fbsd-current@mawer.org) Received: from outbound.icp-qv1-irony-out1.iinet.net.au (outbound.icp-qv1-irony-out1.iinet.net.au [203.59.1.108]) by mx1.freebsd.org (Postfix) with ESMTP id 6A8E28FC18; Wed, 20 Aug 2008 06:08:41 +0000 (UTC) (envelope-from fbsd-current@mawer.org) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AikBAOxOq0jLzq3r/2dsb2JhbAAItU6BWw X-IronPort-AV: E=Sophos;i="4.32,238,1217779200"; d="scan'208";a="371944787" Received: from unknown (HELO [10.24.1.1]) ([203.206.173.235]) by outbound.icp-qv1-irony-out1.iinet.net.au with ESMTP; 20 Aug 2008 13:58:31 +0800 Message-ID: <48ABB1FA.5070609@mawer.org> Date: Wed, 20 Aug 2008 15:56:10 +1000 From: Antony Mawer User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: "M. Warner Losh" References: <20080819211814.6CD685B4D@mail.bitblocks.com> <20080819.160510.104119134.imp@bsdimp.com> <48AB566B.5010507@mawer.org> <20080819.180450.-867152686.imp@bsdimp.com> In-Reply-To: <20080819.180450.-867152686.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: usb@freebsd.org, current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: HEADSUP new usb code coming in. X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2008 06:08:42 -0000 M. Warner Losh wrote: > In message: <48AB566B.5010507@mawer.org> > Antony Mawer writes: > : Warner Losh wrote: > : > From: Bakul Shah > : > Subject: Re: HEADSUP new usb code coming in. > : > Date: Tue, 19 Aug 2008 14:18:13 -0700 > : > > : >> On Tue, 19 Aug 2008 22:44:20 +0200 Hans Petter Selasky wrote: > : >>> New stuff (all of which I can remember right now): > : >> ... > : >> > : >> Accidentally unplugging a mounted USB disk (without > : >> unmounting it) resulted in a hang or a crash. Is this fixed? > : > > : > That's fixed in -current right now with the old stack. It isn't a usb > : > issue at all, but a buffer cache issue. > : > : Is this change that is likely to be MFC'd in time for 7.1? And/or is > : there a specific patch that can manually be applied to -STABLE to fix this? > > I should spend the time to dig into the changes in current. There > turned out to be several little changes... And I need to verify all > the edge cases were covered... I'd be happy to test patches if you do end up doing this.. it would be really nice to have in 7.1, or at least available as a patchset if it isn't suitable for MFC (eg. ABI changes)... --Antony