Date: Sat, 13 Jan 2018 00:19:06 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Cy Schubert <cy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327912 - head/sys/contrib/ipfilter/netinet Message-ID: <201801130819.w0D8J6gn006347@slippy.cwsent.com> In-Reply-To: Message from Cy Schubert <cy@FreeBSD.org> of "Sat, 13 Jan 2018 08:16:10 %2B0000." <201801130816.w0D8GAfG024087@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <201801130816.w0D8GAfG024087@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Sat Jan 13 08:16:10 2018 > New Revision: 327912 > URL: https://svnweb.freebsd.org/changeset/base/327912 > > Log: > Though this block of code is not used by FreeBSD, correct a call to > sprintf() with a macro call to SNPRINTF similar to other calls to > SNPRINTF within this same block. > > MFC after: 1 week > > Modified: > head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c > > Modified: head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c > ============================================================================= > = > --- head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c Sat Jan 13 04:53:04 201 > 8 (r327911) > +++ head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c Sat Jan 13 08:16:10 201 > 8 (r327912) > @@ -2136,7 +2136,7 @@ ipf_p_ftp_eprt6(softf, fin, ip, nat, ftp, dlen) > SNPRINTF(s, left, "%x:%x", a >> 16, a & 0xffff); > left -= strlen(s); > s += strlen(s); > - sprintf(s, "|%d|\r\n", port); > + SNPRINTF(s, left, "|%d|\r\n", port); > #else > (void) sprintf(s, "EPRT %c2%c", delim, delim); > s += strlen(s); Lest anyone fret, sprintf --> snprintf for ipfilter is being worked on and is currently stashed in one of my working directories. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801130819.w0D8J6gn006347>