From owner-svn-src-head@freebsd.org Fri Feb 24 21:02:51 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75AF1CEB629; Fri, 24 Feb 2017 21:02:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3C57B1685; Fri, 24 Feb 2017 21:02:51 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id s67so4334299pgb.1; Fri, 24 Feb 2017 13:02:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=NsylnvdjXnmmZutbH0MWvwQ137VEFZ0pK6LcX5Q8Yjs=; b=I8dJ4rl1+QHU4j4jEKPRKJY+dHLy8MSViBZwafdp4M4GPcZlxmOo+hPBtzXlFb8rSg efL9hw8ISFDKTKqvgbmfJD4R1cIvdFJdSJNxNUpj3o5PiMFaf/5LtayGYLk7u1TbCbea PC/WYjC6SJkneIMyCUrjmlk406fdx1y+IF7wbA1C19WapsS5u8W8vbLHXV1CKRbWApNB jII4vi10ASHQajSUxL/YJ4pmRCY59CFICq1vWGO7bzAimGEatolGOm5d/g5XXQQj43O3 44JKO6ah6aRZykEVDUrtsJn11UGrW5xuEB2BdJUlo3usUQIQyQnsjFfCLFVajFY5LKxn V3gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=NsylnvdjXnmmZutbH0MWvwQ137VEFZ0pK6LcX5Q8Yjs=; b=r6FIkdiQNZs/2KaPVmi81eGtEdhlNYKfOguE+S/yPeEFY779U+G29WaYiJicpRvVQo jrBJxQWipPvzr5Grb+N5RLkoATlisn6L/uV9JjaplGgyLv8uBl8gP8YcrRekXEGETILr 31jrOQ2dZbDgSNWqv08c9VuBInxO7hOJ5Sg0uh8k24J7jt+H4ZrCNfSjjzdP8LAr/Qae piawyxDDD4yAVIbZAWbDlq7+vCN2MxcxPN9A9dI3orRzNfR9Nkq2V4lV8+9gCXHF3k/W kex92k0Puofl5ftzEXQFYZ1+aGv1i573vUjNMs95kjuMmJNtW77MIPn9PiC9GoyAQnW1 X4Aw== X-Gm-Message-State: AMke39m117szGcPYr/qQaYv/kNO334pXffG5I8S9ZHa0PmWJjwigsVQ5lUBWsRvTIOczoQ== X-Received: by 10.98.36.92 with SMTP id r89mr936062pfj.3.1487970170485; Fri, 24 Feb 2017 13:02:50 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id r12sm6006109pgn.26.2017.02.24.13.02.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Feb 2017 13:02:49 -0800 (PST) Subject: Re: svn commit: r314189 - head/lib/libcam Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5975614E-6F25-463B-A3BD-086AF3A1614E"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <1487950593.25520.20.camel@freebsd.org> Date: Fri, 24 Feb 2017 13:02:48 -0800 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <769272AC-D30C-4C69-B4D3-9805B9FFC28D@gmail.com> References: <201702240624.v1O6OdRr094467@repo.freebsd.org> <1487950593.25520.20.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 21:02:51 -0000 --Apple-Mail=_5975614E-6F25-463B-A3BD-086AF3A1614E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 24, 2017, at 07:36, Ian Lepore wrote: >=20 > On Fri, 2017-02-24 at 06:24 +0000, Ngie Cooper wrote: >> Author: ngie >> Date: Fri Feb 24 06:24:39 2017 >> New Revision: 314189 >> URL: https://svnweb.freebsd.org/changeset/base/314189 >>=20 >> Log: >> Fix up NULL/'\0' uses and fix 2 derefs after NULL >>=20 >> MFC after: 2 weeks >> Reported by: Coverity >> CID: 1018898, 1018899 >> Differential Revision: https://reviews.freebsd.org/D6142 >> Sponsored by: Dell EMC Isilon >>=20 >> Modified: >> head/lib/libcam/scsi_cmdparse.c >>=20 >> Modified: head/lib/libcam/scsi_cmdparse.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- head/lib/libcam/scsi_cmdparse.c Fri Feb 24 01:39:12 2017 >> (r314188) >> +++ head/lib/libcam/scsi_cmdparse.c Fri Feb 24 06:24:39 2017 >> (r314189) >> @@ -128,14 +128,14 @@ do_buff_decode(u_int8_t *buff, size_t le >> *(va_arg(*ap, int *)) =3D (ARG); \ >> assigned++; \ >> } \ >> - field_name[0] =3D 0; \ >> + field_name[0] =3D '\0'; \ >=20 > Is coverity seriously complaining about using 0 instead of '\0'? What > possible *real* benefit (not just shutting up coverity) does this = churn > bring? Warner made the same comment. It was actually a combination of issues brought up by Coverity = and coccinelle (badzero.cocci). The forward-NULL CIDs noted were pointed = out by Coverity. The NULL/=E2=80=98\0=E2=80=99 use issues were pointed = out by coccinelle. Thanks! -Ngie --Apple-Mail=_5975614E-6F25-463B-A3BD-086AF3A1614E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYsJ94AAoJEPWDqSZpMIYVniIQANU5r6hhcQVnXMTZHgGotzuk dQkaW876l2MnzH32vkCkgyeeBQyMIsX1Mb7kU6W3NsDy8A/FTcQyhYXJQtUn1Kv8 Pb4tbwz7xczJ7USL65boY5k7ArCSJKHCoff3tt1i/UkhSQ8S96+/K+CHY+2BveFU 2F4A9AlKCBA2Kyq8iWmgxUa59cj6jzm3BwT4CrxfMa9AJZNsYnMDrdUELCI0ZD/z yR7qIZ3MLMg/U6UKnA7uYeqnTFiiuNw6ofxlA3hFhxcBxa0jbggu+zVshke7oY/1 z5zZx4REsgJ4RRT25CAYURwMQZprRR9SpIobYLFzht+5derzXUzpCLW3W08fOgr9 JbqxbFGJMLXCdGDVn7JE0A/Qv7GKWt0Yese9m2en21N51ZyWbl70AOfrDbadlGiy F9OGI7HhQdpsHtNsIXY3j1OxwzYUniln7TLcxKetGTERfWsikhGvvz3dwCf+OYQk Ptyb2MNDH8AD9gHmxIfX/6gWrhohMtD8aV9H1zJbaKmsphXBy1vjWoo1XFUxYJ3H 7RJlzcWrK7LSev2MU3bwHOqhyEvX99BM+kqOM3vovtQg+v0t4QtFRzhBSD8y5fam fsFRV3kyPFrQx7uwTBalkUfQPyYoMiDhipS3I+V8JFBAGYGuGgo7y3bZk6fRgvip IIBBo3MAPywWIfYBLv7g =qawt -----END PGP SIGNATURE----- --Apple-Mail=_5975614E-6F25-463B-A3BD-086AF3A1614E--