Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Jun 1997 00:37:47 -0700 (PDT)
From:      Satoshi Asami <asami@FreeBSD.ORG>
To:        Nakai@Mlab.t.u-tokyo.ac.jp, asami@FreeBSD.ORG, freebsd-ports@FreeBSD.ORG
Subject:   Re: ports/3772
Message-ID:  <199706040737.AAA01065@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
Synopsis: Fixed port: giftool-1.0

State-Changed-From-To: open-closed
State-Changed-By: asami
State-Changed-When: Wed Jun 4 00:36:13 PDT 1997
State-Changed-Why: 

Thanks, committed.  By the way, here are the changes I made
(orig + your patch vs. orig + your patch + my mods):

===
diff -ur giftool/Makefile giftool.new/Makefile
--- giftool/Makefile	Wed Jun  4 00:35:44 1997
+++ giftool.new/Makefile	Wed Jun  4 00:26:54 1997
@@ -1,6 +1,6 @@
 # New ports collection makefile for:   giftool
 # Version required:    1.0
-# Date created:        7 March 1997
+# Date created:        14 October 1996
 # Whom:                Yukihiro Nakai <Nakai@Mlab.t.u-tokyo.ac.jp>
 #
 # $Id: Makefile,v 1.3 1996/12/07 09:28:43 max Exp $
@@ -18,25 +18,25 @@
 ALL_TARGET=	giftool
 
 pre-clean:
-	@ rm -f ${PATCHDIR}/*
+	@${RM} -f ${PATCHDIR}/patch-a[bc]
 
 pre-patch:
 .if defined(RETVALUE)
-	@ echo "Return value patch enabled....."
-	@ cp ${FILESDIR}/patch-aa ${PATCHDIR}
+	@${ECHO_MSG} "Return value patch enabled....."
+	@${CP} ${FILESDIR}/patch-aa ${PATCHDIR}
 .endif
 .if defined(MALLOCSIZE)
-	@ echo "Malloc size improve parch enabled....."
-	@ cp ${FILESDIR}/patch-ab ${PATCHDIR}
+	@${ECHO_MSG} "Malloc size improve parch enabled....."
+	@${CP} ${FILESDIR}/patch-ab ${PATCHDIR}
 .endif
 
 do-install:
-	@ ${INSTALL_PROGRAM} ${WRKSRC}/giftool ${PREFIX}/bin
-	@ ${MKDIR} -p ${PREFIX}/share/doc/giftool
-	@ for file in COPYRIGHT README; do \
-		${INSTALL_DATA} ${WRKSRC}/$$file ${PREFIX}/share/doc/giftool; \
-	done
-	@ ${INSTALL_DATA} ${FILESDIR}/post-install-notes ${PREFIX}/share/doc/giftool
+	${INSTALL_PROGRAM} ${WRKSRC}/giftool ${PREFIX}/bin
+	${MKDIR} ${PREFIX}/share/doc/giftool
+.for file in COPYRIGHT README
+	${INSTALL_DATA} ${WRKSRC}/${file} ${PREFIX}/share/doc/giftool
+.endfor
+	${INSTALL_DATA} ${FILESDIR}/post-install-notes ${PREFIX}/share/doc/giftool
 
 post-install:
 .if !defined(BATCH)
diff -ur giftool/pkg/PLIST giftool.new/pkg/PLIST
--- giftool/pkg/PLIST	Wed Jun  4 00:35:45 1997
+++ giftool.new/pkg/PLIST	Wed Jun  4 00:26:17 1997
@@ -2,3 +2,4 @@
 share/doc/giftool/COPYRIGHT
 share/doc/giftool/README
 share/doc/giftool/post-install-notes
+@dirrm share/doc/giftool
===

Please don't change the "date created", that's the creation date, not
modification date.  Also you tried to remove the @dirrm, which doesn't
make any sense....



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199706040737.AAA01065>