From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Nov 5 05:10:01 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB94816A41A for ; Mon, 5 Nov 2007 05:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A0AAE13C4B5 for ; Mon, 5 Nov 2007 05:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lA55A1X3006241 for ; Mon, 5 Nov 2007 05:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lA55A1IG006240; Mon, 5 Nov 2007 05:10:01 GMT (envelope-from gnats) Resent-Date: Mon, 5 Nov 2007 05:10:01 GMT Resent-Message-Id: <200711050510.lA55A1IG006240@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Philip M. Gollucci" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E316616A46B for ; Mon, 5 Nov 2007 05:03:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id D859D13C491 for ; Mon, 5 Nov 2007 05:03:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lA553j5D095511 for ; Mon, 5 Nov 2007 05:03:45 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id lA553jSP095510; Mon, 5 Nov 2007 05:03:45 GMT (envelope-from nobody) Message-Id: <200711050503.lA553jSP095510@www.freebsd.org> Date: Mon, 5 Nov 2007 05:03:45 GMT From: "Philip M. Gollucci" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/117832: ports-mgmt/portlint: [PATCH]: allow [ to start COMMENT X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2007 05:10:01 -0000 >Number: 117832 >Category: ports >Synopsis: ports-mgmt/portlint: [PATCH]: allow [ to start COMMENT >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Nov 05 05:10:01 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Philip M. Gollucci >Release: FreeBSD 8.0-CURRENT >Organization: Riderway Inc. >Environment: FreeBSD home.p6m7g8.net 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Nov 4 01:36:52 EDT 2007 pgollucci@home.p6m7g8.net:/usr/obj/usr/src/sys/HOME i386 >Description: Filed b/c of rejected http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/117120 to allow things like [X]Emacs Something like (V)im would be similar I guess, but I didn't include them here. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: portlint.pl =================================================================== RCS file: /home/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v retrieving revision 1.95 diff -u -r1.95 portlint.pl --- portlint.pl 17 Aug 2007 17:11:40 -0000 1.95 +++ portlint.pl 5 Nov 2007 03:56:44 -0000 @@ -2279,7 +2279,7 @@ &perror("WARN", $file, -1, "unless this is a master port, COMMENT has to be set by \"=\", ". "not by \"$1=\".") unless ($masterport); } else { # check for correctness - if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #" + if (($makevar{COMMENT} !~ /^["\[0-9A-Z]/) || ($makevar{COMMENT} =~ m/\.$/)) { #" &perror("WARN", $file, -1, "COMMENT should begin with a capital, and end without a period"); } elsif (length($makevar{COMMENT}) > 70) { &perror("WARN", $file, -1, "COMMENT exceeds 70 characters limit."); >Release-Note: >Audit-Trail: >Unformatted: