From owner-svn-src-head@FreeBSD.ORG Sun Dec 21 16:45:14 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 07093793; Sun, 21 Dec 2014 16:45:14 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CEDB53188; Sun, 21 Dec 2014 16:45:13 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1Y2jd2-000PM7-57; Sun, 21 Dec 2014 16:45:12 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id sBLGjBg6016275; Sun, 21 Dec 2014 09:45:11 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/kkgXnjPp9+ipkTBcl8+oF Message-ID: <1419180311.1018.66.camel@freebsd.org> Subject: Re: svn commit: r275961 - head/sys/arm/conf From: Ian Lepore To: Alexey Dokuchaev Date: Sun, 21 Dec 2014 09:45:11 -0700 In-Reply-To: <20141221080739.GB27290@FreeBSD.org> References: <201412201815.sBKIFOSq060122@svn.freebsd.org> <20141221080739.GB27290@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Andrew Turner , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Dec 2014 16:45:14 -0000 On Sun, 2014-12-21 at 08:07 +0000, Alexey Dokuchaev wrote: > On Sat, Dec 20, 2014 at 06:15:24PM +0000, Andrew Turner wrote: > > Author: andrew > > Date: Sat Dec 20 18:15:23 2014 > > New Revision: 275961 > > URL: https://svnweb.freebsd.org/changeset/base/275961 > > > > Log: > > Clean up to use the standard style of "options \t" and "device\t\t" > > > > options HZ=500 # Scheduling quantum is 2 milliseconds. > > [...] > > -options KDB # Enable kernel debugger support. > > +options KDB # Enable kernel debugger support. > > # For minimum debugger support use KDB_TRACE, for interactive use DDB. > > -#options KDB_TRACE # Print a stack trace for a panic. > > -options DDB # Support DDB. > > +#options KDB_TRACE # Print a stack trace for a panic. > > +options DDB # Support DDB. > > # For full debugger support use this instead: > > -#options GDB # Support remote GDB. > > +#options GDB # Support remote GDB. > > [...] > > It also would be nice if we removed trailing dots in comments one day, > preferreably across all config files we have in the tree. > > ./danfe > Why? I thought our rule about comments is that they're complete sentences, punctuated as such. Of course, I also thought we had a rule that 'device' and 'options' in kernel config is always followed by two spaces then a tab, so that you can comment out lines without ruining the indent, and apparently that's not true either (and I have no idea where I got that notion). -- Ian