From owner-svn-src-all@freebsd.org Fri Jul 10 11:10:56 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 952B83D0F; Fri, 10 Jul 2015 11:10:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F32DA90F; Fri, 10 Jul 2015 11:10:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t6ABAoiT022768 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 10 Jul 2015 14:10:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t6ABAoiT022768 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t6ABAoVV022767; Fri, 10 Jul 2015 14:10:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 10 Jul 2015 14:10:50 +0300 From: Konstantin Belousov To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285356 - in head/sys: compat/cloudabi kern sys Message-ID: <20150710111050.GU2080@kib.kiev.ua> References: <201507101101.t6AB1VYe002159@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201507101101.t6AB1VYe002159@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 11:10:56 -0000 On Fri, Jul 10, 2015 at 11:01:31AM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Fri Jul 10 11:01:30 2015 > New Revision: 285356 > URL: https://svnweb.freebsd.org/changeset/base/285356 > > Log: > fd: split kern_dup flags argument into actual flags and a mode > > Tidy up the code inside to switch on the mode. > + MPASS(mode < FDDUP_LASTMODE); Since you started the FDDUP_ modes enum from 1, this assert does not fully validate the mode. Am I wrong ? > +/* Operation types for kern_dup(). */ > +enum { > + FDDUP_NORMAL = 0x01, /* dup() behavior. */ > + FDDUP_FCNTL, /* fcntl()-style errors. */ > + FDDUP_FIXED, /* Force fixed allocation. */ > + FDDUP_MUSTREPLACE, /* Target must exist. */ > + FDDUP_LASTMODE, > +}; > + > /* Flags for kern_dup(). */ > -#define FDDUP_FIXED 0x1 /* Force fixed allocation. */ > -#define FDDUP_FCNTL 0x2 /* fcntl()-style errors. */ > -#define FDDUP_CLOEXEC 0x4 /* Atomically set FD_CLOEXEC. */ > -#define FDDUP_MUSTREPLACE 0x8 /* Target must exist. */ > +#define FDDUP_CLOEXEC 0x1 /* Atomically set FD_CLOEXEC. */ Consider using different prefixes for mode/flags ?