From owner-svn-ports-head@freebsd.org  Wed Oct 31 15:02:54 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A91510DC61B;
 Wed, 31 Oct 2018 15:02:54 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 50A1B79A23;
 Wed, 31 Oct 2018 15:02:54 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Received: from ogg.in.absolight.net (ogg.in.absolight.net
 [IPv6:2a01:678:ab:50::42:42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: mat/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 9E74BBE5D;
 Wed, 31 Oct 2018 15:02:53 +0000 (UTC) (envelope-from mat@FreeBSD.org)
Date: Wed, 31 Oct 2018 16:02:52 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Larry Rosenman <ler@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r483437 - in head/mail/dovecot: . files
Message-ID: <20181031150252.p4lhmlaposwurdgr@ogg.in.absolight.net>
References: <201810292328.w9TNSRHm018030@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="t44gpofmv3dg4bvu"
Content-Disposition: inline
In-Reply-To: <201810292328.w9TNSRHm018030@repo.freebsd.org>
User-Agent: NeoMutt/20180622
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2018 15:02:54 -0000


--t44gpofmv3dg4bvu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 29, 2018 at 11:28:27PM +0000, Larry Rosenman wrote:
> Modified: head/mail/dovecot/files/dovecot.in
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/mail/dovecot/files/dovecot.in	Mon Oct 29 23:25:58 2018	(r483436)
> +++ head/mail/dovecot/files/dovecot.in	Mon Oct 29 23:28:26 2018	(r483437)
> @@ -60,6 +60,14 @@ for config in ${dovecot_config}; do
>  	required_files=3D"${config}"
>  	command_args=3D"-c ${config}"
>  	if [ -s ${config} ]; then
> +               ${command} ${command_args} -a 2>/dev/null
> +                if [ $? -ne 0 ]; then

Never test for $?.  This should be:

if ${command} ${command_args} -a 2>/dev/null; then

All the rationale in https://github.com/koalaman/shellcheck/wiki/SC2181.


--=20
Mathieu Arnold

--t44gpofmv3dg4bvu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvZxBtfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkiTpBAAsIw6JEpciRQb8CeNpvzM4JRd06jRW0IB9wxLlzHYsIKn7+k2ubVLJWO/
AqLAgwCGQcwdPo9B6XWLYY1eFqN+rvdGRJrt/UUE5Gh54YAuHNQ2/mxOIYjKGeRx
BoFj3QFnvnxmEJjC7PoCyq+0P7DiMhU5dteIRz6xnc6hR+AqN6BtvlIbwaMwl+lO
K/BQC315EWv7Di5VXD7BdyBwBodvHF9rBihggdYQb0g4vYIObeQyV8lUIBGIfHGa
H8uv/twkl4VoVmabesqQ3hjRi0wyQriyU3Pm2fIK75bkz1lq3ZqyNgrkbL/8uCvo
oVPTUTDbUKhSZEgl3JBN3qoezrUBkAx/ZNJoAnjGW2JfdMMI2b2M0ugWoiDNXtWL
/5YJCYYby6FPXMH7ldgzrkDcGH0Xk9M9pOdzV09oiWdpZU+ThNK4x6yCO/YQPGAB
HAbKv9EGEyRBBuVYrArW+QCKk2B33FY/irMyvq/8pp561M0PGfDe9lngGe0zOp61
ugNTUjTKSj0iJ07B7C0xhufF+rSixZ6Z6x3rcp5OHIYGTotXAIsrSKlRq2BSzNfE
lb00tvxNFz8wqj7VD9GWT/pTkOBVF01QMNqqTbf9Lfndq9zGpMTV1w+dMXt6zqUF
5pJ7OPUYFSrmkSNqiR5m686DxuzMmpjkZ3c7xcM/m88mTud60b4=
=vetj
-----END PGP SIGNATURE-----

--t44gpofmv3dg4bvu--