From owner-freebsd-stable@FreeBSD.ORG  Wed Dec 26 18:48:44 2007
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26F3E16A419;
	Wed, 26 Dec 2007 18:48:44 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id E61C213C474;
	Wed, 26 Dec 2007 18:48:43 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id lBQIhfWD034032;
	Wed, 26 Dec 2007 11:43:41 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Wed, 26 Dec 2007 11:48:12 -0700 (MST)
Message-Id: <20071226.114812.1649771240.imp@bsdimp.com>
To: henrik@gulbra.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <1198689316.1119.382.camel@Particle>
References: <200712260038.11546@aldan>
	<20071226.003547.-932932005.imp@bsdimp.com>
	<1198689316.1119.382.camel@Particle>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: stable@FreeBSD.org, freebsd-usb@FreeBSD.org, mi+kde@aldan.algebra.com
Subject: Re: usb/umass, devfs: this sucks
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Dec 2007 18:48:44 -0000

In message: <1198689316.1119.382.camel@Particle>
            Henrik Gulbrandsen <henrik@gulbra.net> writes:
: Look at it from my perspective: I would be happy to complete my fix for
: the infamous five-year-old usb/46176, so people can finally detach umass
: devices without having to manually unmount them first. However, it will
: undoubtedly take a non-trivial amount of time to reproduce and eliminate
: the remaining issues.

There's no patches in this bug.

: I'm more likely to put in that effort if I believe
: that my patches may actually end up in CURRENT, but if a one-line fix
: such as that in usb/78984 has not been applied after more than a year,
: how long will it take for patches that involve multiple subsystems?

The patch in this bug is wrong.  There are devices that are an odd
number of sectors.  This is one of the places where the obvious patch
isn't necessarily right.

Warner