From owner-freebsd-numerics@freebsd.org Wed Sep 13 06:53:46 2017 Return-Path: Delivered-To: freebsd-numerics@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CA3BE10573 for ; Wed, 13 Sep 2017 06:53:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8AAFE75F1F for ; Wed, 13 Sep 2017 06:53:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8D6rjs7071923 for ; Wed, 13 Sep 2017 06:53:46 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-numerics@FreeBSD.org Subject: [Bug 222247] libmsun tests does not compile during a buildworld Date: Wed, 13 Sep 2017 06:53:46 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rlibby@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rlibby@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 06:53:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222247 --- Comment #6 from Ryan Libby --- (In reply to Bertrand Petit from comment #5) For the underlying bug, yes I think deconflicting the namespace is the right approach, rather than having libmsun try to use the kernel macros. I think there are still two different problems: - Use of reserved identifiers. Neither libmsum nor the kernel headers should be defining identifiers that start with double underscores. - Kernel header namespace pollution. The kernel macros, after being renamed to something not reserved, should be #undef'd at the end of the headers. Attachment 186320 moves the i386 kernel header names out of the way, but leaves the amd64 ones, and still uses inappropriate reserved names. Thanks for your interest. I'm also trying to remove places where we silence warnings. I suggest we get the bug at hand resolved and then clone a new bug targeting head to do this cleanup, since we aren't going to do it by direct commit to stable/11 anyway. If you are familiar with Phabricator (https://wiki.freebsd.org/Phabricator), feel free to submit a patch there. --=20 You are receiving this mail because: You are on the CC list for the bug.=