Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 4 Nov 2012 13:48:43 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Jaakko Heinonen <jh@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r242511 - head/sbin/fsck_msdosfs
Message-ID:  <20121104124843.GR1399@garage.freebsd.pl>
In-Reply-To: <201211030918.qA39IcH6030403@svn.freebsd.org>
References:  <201211030918.qA39IcH6030403@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--RpDyejMaDGJhP2PU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 03, 2012 at 09:18:38AM +0000, Jaakko Heinonen wrote:
> Author: jh
> Date: Sat Nov  3 09:18:37 2012
> New Revision: 242511
> URL: http://svn.freebsd.org/changeset/base/242511
>=20
> Log:
>   Print a newline after the error message.
>  =20
>   PR:		bin/168447
>   Submitted by:	Boris Kochergin
>=20
> Modified:
>   head/sbin/fsck_msdosfs/check.c
>=20
> Modified: head/sbin/fsck_msdosfs/check.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sbin/fsck_msdosfs/check.c	Sat Nov  3 04:56:08 2012	(r242510)
> +++ head/sbin/fsck_msdosfs/check.c	Sat Nov  3 09:18:37 2012	(r242511)
> @@ -68,6 +68,7 @@ checkfilesys(const char *fname)
> =20
>  	if (dosfs < 0) {
>  		perr("Can't open `%s'", fname);
> +		printf("\n");

Why not just add \n to perr()? Doesn't perr() print at stderr, not
stdout?

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--RpDyejMaDGJhP2PU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCWZCsACgkQForvXbEpPzSpfwCdEnH+/G6EAlerUlCQL6i6nEOn
MHEAoOL+Pq9GgudAUtl1lmwElOh5++Lq
=+1JO
-----END PGP SIGNATURE-----

--RpDyejMaDGJhP2PU--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121104124843.GR1399>