From nobody Mon Sep 4 17:05:00 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RfZkk4HKjz4sMdN; Mon, 4 Sep 2023 17:05:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RfZkk22d5z4SxJ; Mon, 4 Sep 2023 17:05:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-58d40c2debeso16590597b3.2; Mon, 04 Sep 2023 10:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693847101; x=1694451901; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Ur6PHKlsJUqc/qt+QfqPY/7wFvwcDeU72T/JsrFHVNQ=; b=cmecwnDPfN2FpafzYw8rwymI18+4CwU+L3VKtWC8qBE4zvBk5P5hUDCaMyzU9VGzFB hI9qx1zHdzof1VRpaciR5fbuyJTep3xiGFCUluwd5gVVt0eUfb9t9BMUW19z3Wc9bOS1 pbyW7G1I5EjdHigJjd8n38/X5REgIkq9AqLcF+M9FeEjfz9K3W2Kjb4ktT1UgO+eMQPZ iVkBX8cBGotznIQuPU5DG9T6XQw+nMt7nUBm9bd1Mw7bZDXIpOEPl7n2OCnnyHhJ9GET EyKZrc3c2ms/FUn5D/YPLvUnxrrawQSk9neHjmOC+yVef+7e66ElpnNHx7hQjomls+Ji aYtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693847101; x=1694451901; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ur6PHKlsJUqc/qt+QfqPY/7wFvwcDeU72T/JsrFHVNQ=; b=KwuzQtFLhAvZZtZy9ZdoqFN0V/7KEozVBf9PirRdbnmfY+s7QLJBA0uavYJFTjcZmO 0KjqJQUzIDyJYi21vvSrxVNFRXP/q/LUHeSa14/ySYsj6P3oZ5RLed2KvSOBJ1Ca1QXV s8PWYGac0yiogoLqsiLxNmpr8DGWRklDQI5UV9qYEqIttWYD6ryaIEguaLEo/ARkfkCf 7fIoV4/+vkG8SVFrWV3sDVjkpYgaY4Bpvn8W+yXgc/9DR9Ntw1ugPqdaZUBdNqXmpbIT 2Z96C9lePNDYTgo+M5W3dW6TQXq+gKg9IEHqRmYYQdMT7/jmgeFNhmHIfm0bBE5FAsG/ I9WQ== X-Gm-Message-State: AOJu0YxBdnGLDl0hhfN2PEhX6p8ot6uNuzcG3lnvOtKOeqxPw7dBiocI SfaJoT48t4b0o2BiZerPpJE= X-Google-Smtp-Source: AGHT+IE/SVjFsNwNSey1Aoq9/hX0dww+OXhVeRMgvWhk7IkLd0H0kq/MKf6qTqf/Qy5MRJQmTLg98A== X-Received: by 2002:a81:9988:0:b0:59a:e672:5a03 with SMTP id q130-20020a819988000000b0059ae6725a03mr2828502ywg.44.1693847101261; Mon, 04 Sep 2023 10:05:01 -0700 (PDT) Received: from [192.168.1.66] (104-55-12-234.lightspeed.knvltn.sbcglobal.net. [104.55.12.234]) by smtp.gmail.com with ESMTPSA id eh10-20020a05690c298a00b0059adc0c4392sm721868ywb.140.2023.09.04.10.05.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 10:05:00 -0700 (PDT) Message-ID: <5605506b-5059-fb72-3e5a-741863d54444@FreeBSD.org> Date: Mon, 4 Sep 2023 13:05:00 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: An attempted test of main's "git: 2ad756a6bbb3" "merge openzfs/zfs@95f71c019" that did not go as planned Content-Language: en-US To: Mark Millard Cc: dev-commits-src-main@freebsd.org, Current FreeBSD References: <673A446E-6F94-451E-910F-079F678C5289@yahoo.com> <2BDD30B5-6248-4EC3-83C8-0499E0717D1D@yahoo.com> <69028684-c2cd-8f0c-617f-d0763c08dbe4@FreeBSD.org> <8D832756-6754-4D1E-AE8D-E716FE08F747@yahoo.com> From: Alexander Motin In-Reply-To: <8D832756-6754-4D1E-AE8D-E716FE08F747@yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4RfZkk22d5z4SxJ On 04.09.2023 11:45, Mark Millard wrote: > On Sep 4, 2023, at 06:09, Alexander Motin wrote: >> per_txg_dirty_frees_percent is directly related to the delete delays we see here. You are forcing ZFS to commit transactions each 5% of dirty ARC limit, which is 5% of 10% or memory size. I haven't looked on that code recently, but I guess setting it too low can make ZFS commit transactions too often, increasing write inflation for the underlying storage. I would propose you to restore the default and try again. > > While this machine is different, the original problem was worse than > the issue here: the load average was less than 1 for the most part > the parallel bulk build when 30 was used. The fraction of time waiting > was much longer than with 5. If I understand right, both too high and > too low for a type of context can lead to increased elapsed time and > getting it set to a near optimal is a non-obvious exploration. IIRC this limit was modified several times since originally implemented. May be it could benefit from another look, if default 30% is not good. It would be good if generic ZFS issues like this were reported to OpenZFS upstream to be visible to a wider public. Unfortunately I have several other project I must work on, so if it is not a regression I can't promise I'll take it right now, so anybody else is welcome. > An overall point for the goal of my activity is: what makes a > good test context for checking if ZFS is again safe to use? > May be other tradeoffs make, say, 4 hardware threads more > reasonable than 32. Thank you for your testing. The best test is one that nobody else run. It also correlates with the topic of "safe to use", which also depends on what it is used for. :) -- Alexander Motin