From owner-svn-src-all@freebsd.org Thu May 26 18:18:09 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B04AB4B852; Thu, 26 May 2016 18:18:09 +0000 (UTC) (envelope-from peter@wemm.org) Received: from smtp2.wemm.org (smtp2.wemm.org [IPv6:2001:470:67:39d::78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp2.wemm.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1794412CD; Thu, 26 May 2016 18:18:09 +0000 (UTC) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (canning.wemm.org [192.203.228.65]) by smtp2.wemm.org (Postfix) with ESMTP id C3DC7CCD; Thu, 26 May 2016 11:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=m20140428; t=1464286688; bh=TIlevw0EqVITpSr4tPhOTiHmfKvwMHR7FBuekkRJoaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=iZkyHnQmOf+MVqHEaS5yQ6y/i2kIIKLzZU9cWtpNK/dKVa3XWf8dBzmCaCdMbnLsi nmPX/L0tDZ+G4KFndahw0Ml9mVFVpLI7wSxlWMmekJKudWv/EaVvqyuMCsCp7Aexsj 28AYhm/Pr1vEvq4IZUiUB3XrQGs89E3CHVNjrrdA= From: Peter Wemm To: Jilles Tjoelker Cc: John Baldwin , Alan Somers , Peter Wemm , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r300557 - head/usr.sbin/apmd Date: Thu, 26 May 2016 11:18:03 -0700 Message-ID: <47237366.96sRQ3voAD@overcee.wemm.org> User-Agent: KMail/4.14.3 (FreeBSD/11.0-CURRENT; KDE/4.14.3; amd64; ; ) In-Reply-To: <20160526175420.GA31199@stack.nl> References: <201605240315.u4O3FkMt001717@repo.freebsd.org> <2084098.Ir36lcS1Gf@ralph.baldwin.cx> <20160526175420.GA31199@stack.nl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1848827.f2x5KYXUg7"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 18:18:09 -0000 --nextPart1848827.f2x5KYXUg7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Thursday, May 26, 2016 07:54:20 PM Jilles Tjoelker wrote: > On Tue, May 24, 2016 at 08:52:32AM -0700, John Baldwin wrote: > > On Monday, May 23, 2016 09:24:41 PM Alan Somers wrote: > > > On Mon, May 23, 2016 at 9:15 PM, Peter Wemm w= rote: > > > > Author: peter > > > > Date: Tue May 24 03:15:46 2016 > > > > New Revision: 300557 > > > > URL: https://svnweb.freebsd.org/changeset/base/300557 > > > >=20 > > > > Log: > > > > It seems is a new prerequisite for after > > > > r300539. Attempt to fix the build for i386. > > > >=20 > > > > Modified: > > > > head/usr.sbin/apmd/apmd.c > > > > head/usr.sbin/apmd/apmdlex.l > > > > head/usr.sbin/apmd/apmdparse.y > > >=20 > > > Are you sure this is necessary, even after 300544? > >=20 > > Actually, we try to avoid nested includes when possible for userlan= d, > > so I'd be inclined to drop the nested include and jus= t > > add to the places that need it. Userland code in the= > > base system is supposed to have or as t= he > > first #include anyway (which apmd was not following), so any fixes = to > > userland are probably style fixes anyway. >=20 > This is traditional BSD convention, but headers specified by POSIX wo= rk > differently. POSIX headers can be included alone, so files that only > include POSIX headers rarely need #include . This often > causes some ugliness in the header file to use hidden names for thing= s > to reduce namespace pollution. >=20 > Since is not specified by POSIX, it is not required to > work without prerequisites. FWIW I have no investment in the commit I made - I needed it to compile= for=20 the cluster. Feel free to change/revert my commit so long as world com= piles. =2D-=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI= 6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 --nextPart1848827.f2x5KYXUg7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJXRz3bAAoJEDXWlwnsgJ4EgQIIANHjw5AVkQjvTr9493oSXrqD qLb5GQLL95B2CMcTK8R121R2AEnaK/QsvebrIwMSrvD7EiKZbvKoCmTWy0tIjMc3 YumfZ0TmCw9NMbQ3rZR1LtECyxKshz+tc8EtfnbipUxZJrc75AFY5txzgQSwNvAN aMKrj9XSk9jCSmjXqa6X/gNzDjg9M73M7L4rzZSq6pEkyYvIk8mXNldKtJfcQ7c0 Lkv64X2TNUtOlNTHQ0ARY2DrIh0rMKdOEhOXSBMab5lHK5C+N5dUy1caIjOHGkxT j+00YGKBWg4xchPLg5ZlFQED+ZEP6zSPPwuMWC0zPzRmEaR4D4kBHg5MZt9HP28= =mt8b -----END PGP SIGNATURE----- --nextPart1848827.f2x5KYXUg7--