From owner-freebsd-security@FreeBSD.ORG Tue Apr 5 08:40:06 2005 Return-Path: Delivered-To: freebsd-security@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2353416A4CE for ; Tue, 5 Apr 2005 08:40:06 +0000 (GMT) Received: from pd4mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC0EF43D4C for ; Tue, 5 Apr 2005 08:40:05 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mr2so.prod.shaw.ca (pd4mr2so-qfe3.prod.shaw.ca [10.0.141.213]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IEG00HJWTETQCA0@l-daemon> for freebsd-security@freebsd.org; Tue, 05 Apr 2005 02:40:05 -0600 (MDT) Received: from pn2ml9so.prod.shaw.ca ([10.0.121.7]) by pd4mr2so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IEG00E7QTETBS7Y@pd4mr2so.prod.shaw.ca> for freebsd-security@freebsd.org; Tue, 05 Apr 2005 02:40:05 -0600 (MDT) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) freebsd-security@freebsd.org; Tue, 05 Apr 2005 02:40:05 -0600 (MDT) Date: Tue, 05 Apr 2005 01:40:03 -0700 From: Colin Percival In-reply-to: <425248D8.1040508@geminix.org> To: Uwe Doering Message-id: <42524EE3.2040102@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.90.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime References: <200504050009.j35099Zr068123@freefall.freebsd.org> <425248D8.1040508@geminix.org> User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050326) cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-05:02.sendfile X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Security issues [members-only posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2005 08:40:06 -0000 Uwe Doering wrote: > + vnode_pager_setsize(vp, 0); > > I wonder, isn't the variable 'vp' actually supposed to be 'ovp' in the > added line? Technically they are identical. 'ovp' is assigned from > 'vp' once in the variable definition section at the start of the function. > > However, using 'vp' when calling vnode_pager_setsize() looks a little > odd given that anywhere else in this function, including another call to > vnode_pager_setsize(), the variable 'ovp' is used instead of 'vp'. I agree that it looks a bit odd; a few people have pointed this out to us (but none of them before it was committed into the CVS tree). That said, it doesn't seem to matter, so I'm not going to go back and change the patch now. Colin Percival