Date: Fri, 07 Oct 2016 08:27:09 +0200 From: Bernard Spil <brnrd@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r423434 - head/security/openssl Message-ID: <a32b089fd0784f0c83b34c0b084ed0ba@FreeBSD.org> In-Reply-To: <ba9aa488-020d-60a0-df8a-d79d38e9f7a0@FreeBSD.org> References: <201610061938.u96JcmrW038201@repo.freebsd.org> <ba9aa488-020d-60a0-df8a-d79d38e9f7a0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-10-07 0:44, Mathieu Arnold wrote: > Le 06/10/2016 à 21:38, Bernard Spil a écrit : >> Author: brnrd >> Date: Thu Oct 6 19:38:48 2016 >> New Revision: 423434 >> URL: https://svnweb.freebsd.org/changeset/ports/423434 >> >> Log: >> security/openssl: Fix ldconfig issue >> >> - OPT_USE= feature does not behave as expected > > I strongly disagree with that comment, the opt_USE works exactly as > expected, and as documented. > >> Reported by: dinoex >> Differential Revision: D8166 >> >> Modified: >> head/security/openssl/Makefile >> >> Modified: head/security/openssl/Makefile >> ============================================================================== >> --- head/security/openssl/Makefile Thu Oct 6 19:35:40 2016 (r423433) >> +++ head/security/openssl/Makefile Thu Oct 6 19:38:48 2016 (r423434) >> @@ -88,7 +88,7 @@ SCTP_CONFIGURE_OFF= no-sctp >> SHARED_CONFIGURE_ON= shared >> SHARED_MAKE_ENV= SHLIBVER=${OPENSSL_SHLIBVER} >> SHARED_PLIST_SUB= SHLIBVER=${OPENSSL_SHLIBVER} >> -SHARED_USE= ldconfig >> +SHARED_USE= ldconfig=yes >> SSE2_CONFIGURE_OFF= no-sse2 >> SSL2_CONFIGURE_ON= enable-ssl2 >> SSL2_CONFIGURE_OFF= no-ssl2 >> >> Hi Mat, From Mk/bsd.options.mk: 499: _u= ${option:C/=.*//g} 500: USE_${_u:tu}+= ${option:C/.*=//g:C/,/ /g} If you forget to add =value to your OPT_USE= feature this will result in USE_FEATURE= feature as there's no `=' to split on. This should either default to something sane (i.e. "yes") or throw an error. Cheers, Bernard.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a32b089fd0784f0c83b34c0b084ed0ba>